Skip to content

Bump Microsoft.Win32.Registry from 4.7.0 to 5.0.0 #1675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 15, 2021

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Apr 29, 2021

Bumps Microsoft.Win32.Registry from 4.7.0 to 5.0.0.

Release notes

Sourced from Microsoft.Win32.Registry's releases.

.NET 5

Release Notes Install Instructions

Repo

.NET 5 RC 2

Release Notes Install Instructions

Repos

.NET 5.0 RC 1

Release Notes Install Instructions

Repos

.NET 5.0 Preview 8

Release Notes Install Instructions

... (truncated)

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Apr 29, 2021
@rjmholt
Copy link
Contributor

rjmholt commented Apr 29, 2021

@dependabot recreate

Bumps [Microsoft.Win32.Registry](https://github.com/dotnet/runtime) from 4.7.0 to 5.0.0.
- [Release notes](https://github.com/dotnet/runtime/releases)
- [Commits](https://github.com/dotnet/runtime/commits/v5.0.0)

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/nuget/Microsoft.Win32.Registry-5.0.0 branch from 2317931 to 0f494a2 Compare April 29, 2021 21:04
Copy link
Collaborator

@bergmeister bergmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With things like that we have to be careful/aware that azure devops runs on ps 7.1 but 7.0 is still supported till December 2022. Due to the difference between .net 3.1 and 5.0 there is a chance it behaves differently. I built and ran it locally on Windows using ps 7.0 and tests passed. Probably good enough as a smoke test as Windows has the biggest test coverage. I am thinking of doing something like pr 1439 for running ps 7.0 and 7.1 in CI, wdyt?

@rjmholt
Copy link
Contributor

rjmholt commented May 14, 2021

I am thinking of doing something like pr 1439 for running ps 7.0 and 7.1 in CI, wdyt?

Yeah I think it's a good idea to be running both current PS 7 platforms in CI, ideally PS 7.2 as well so we can ensure that there are no breaking changes for us in the previews before they're stabilised.

@bergmeister bergmeister merged commit 06f94fb into master May 15, 2021
@dependabot dependabot bot deleted the dependabot/nuget/Microsoft.Win32.Registry-5.0.0 branch May 15, 2021 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants