PSUseCmdletCorrectly fails to detect when mandatory parameters are supplied in a splatted hashtable

[KirkMunro]

Today it seems that PSUseCmdletCorrectly fails to detect when mandatory parameters are supplied to a cmdlet via a splatted hashtable.

Since determining the contents of the hashtable is a runtime activity (and looking at my script it would be difficult if not impossible to do so without running it), I would prefer if this warning wouldn't be generated at all when splatting. Knowing how I use splatting, it is often because building the required parameter set is complicated, in which case this warning shouldn't appear at all.

But, isn't this yet another case where PSScriptAnalyzer is overstepping its bounds? Checking to see if mandatory parameters are used, unless it is obvious (with pipeline support - I noticed there is another bug logged about that) should be something that happens from unit testing, not from analysis IMHO. These types of errors are very easy to understand when they do occur, they tend to occur quickly and be identified through simple testing, and this rule is just generating noise for me right now.

[dotps1]

I am also having this fail when just using the Add-Member cmdlet, something as simple as this:

$array = @([PSObject]'MyFirstObject', [PSObject]'MySecondObject')
$array | ForEach-Object {
     $_ | Add-Member -NotePropertyName 'MyNoteProperty' -NotePropertyValue 'MyNotePropertyValue'
}

I'm not sure what 'Mandatory' property im missing, or how this example is using the Add-Member Cmdlet incorrectly.

Output:

RuleName                            Severity     FileName   Line  Message                                                     
--------                            --------     --------   ----  -------                                                     
PSUseCmdletCorrectly                Warning      Test.ps1   3     Cmdlet 'Add-Member' may be used incorrectly. Please check   
                                                                  that all mandatory parameters are supplied.

[quoctruong]

Hi dotps1, this is a known bug (#71). We are working on fixing it.

[quoctruong]

Fixed with #240