Update SDK version in global.json

[wilmardo]

Summary of the new feature

Update the SDK version in the global.json file since Microsoft offers no download for the 2.1.101 version or compatible patch release (as far as I could find). See on the downloads page that 2.1.300 is lowest offered version.
Right now I cannot build PSScriptAnalyzer without replacing the global.json with an empty json (removing doesn't work because of this).

Proposed technical implementation details (optional)

Change the global.json to:

{
    "sdk": {
        "version": "2.1.401"
    }
}

This should be no problem since this version is included in the Ubuntu image on AppVeyor (see the software list).
Since 2.1.403 is a patch release of 2.1.401 it should work on systems with 2.1.403 installed. See the matching rules of the global.json.

What is the latest version of PSScriptAnalyzer at the point of writing
v1.17.1

[bergmeister]

@wilmardo Just FYI that we have a link to download version 2.1.101 of the SDK here in our main readme here to resolve the issues that you have locally at the moment until the PR gets merged

[wilmardo]

Yeah thanks saw that when updating the PR #1086 👍

When you go to the Microsoft site directly it can't be found under download or the downloads archive.
Also there is no 2.1.1xx Docker image for dotnet this is the main reason why I submitted. I am working on a Dockerized PSScriptAnalyzer

[bergmeister]

Sounds awesome. We have a Windows docker file here already that we use for the release process btw and simple docker examples are here but a docker image would be nice. But as you said yourself, one can just use a newer version of the version of the SDK and it should still build, the version does not need to be matching, therefore I do not understand the issue that you face

[wilmardo]

The main issue is that it doesn't seem to build on 2.1.403, when I try to build it throws an error. I do not have the exact error right now but concluded that it was because 2.1.403 wasn't a patch release of 2.1.101. Since the docs say it then fails:

• If the specified SDK version is found on the machine, that exact version is used.
• If the specified SDK version can't be found on the machine, the latest installed SDK patch version of that version is used. Latest installed SDK patch version can be either release or pre-release - the highest version number wins. In .NET Core 2.1 and higher, the patch versions lower than the patch version specified are ignored in the SDK selection.
• If the specified SDK version and an appropriate SDK patch version can't be found, an error is thrown.

The Dockerfile is on my work PC (not accessible at the moment) but I will create reproducible scenario tomorrow morning to explain the issue a bit better :)

[bergmeister]

Ah, I should have read in more detail, I uninstalled 2.1.101 locally and saw the error. I will try to get your change in as quick as possible once CI systems work again.

[bergmeister]

P.S. Please also watch PR #1082 because after that buildCoreClr.ps1 will not be there any more, you will need to call build.ps1 instead.

[bergmeister]

PR has been merged, will therefore close, please re-open if there is an issue