Skip to content

make ray and semver dependencies optional #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 10, 2021
Merged

Conversation

mchestnut91
Copy link

@mchestnut91 mchestnut91 commented Jun 10, 2021

I noticed that our builds were failing because I did not have ray or semver installed and they were added to btrdb/utils/ray.py with Gabe's serialization work. I was hesitant to add them as requirements because they are only really necessary when the user is trying to use ray with the bindings, so I added a try/except to throw an exception when a user tries to register a custom serializer but does not have these modules installed.

I'm open to feedback on this, this is just the first thing that came to mind.

@mchestnut91 mchestnut91 merged commit 59302b6 into master Jun 10, 2021
@mchestnut91 mchestnut91 deleted the dependencies branch June 10, 2021 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants