Skip to content

modify setup and docs to use new repo #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 26, 2021
Merged

Conversation

mchestnut91
Copy link

This PR updates the setup.py file and the docs to reference the new repo. I believe these changes are sufficient for us to be able to use pypi with this repo, but we will need to test once we've done a new release

@shortcut-integration
Copy link

This pull request has been linked to Clubhouse Story #13150: Modify setup.py, docs, etc. to use new repo.

@@ -26,8 +26,8 @@
# -- Project information -----------------------------------------------------

project = 'btrdb'
copyright = '2019, Michael P. Andersen'
author = 'Michael P. Andersen'
copyright = '2021, PingThingsIO'
Copy link

@looselycoupled looselycoupled May 26, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pingthings here should be referred to as Ping Things, Inc. - Note the space.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds good. Should I change it to that everywhere or just the copyright line?

@looselycoupled
Copy link

You should also look at the following file for changes: https://github.com/PingThingsIO/btrdb-python/blob/master/docs/source/conf.py

@looselycoupled
Copy link

Also, perhaps a new ticket but the URL for the image/badge concerning build status is still pointing to travis and uses the wrong github repo. https://raw.githubusercontent.com/PingThingsIO/btrdb-python/master/docs/source/index.rst

@mchestnut91
Copy link
Author

FYI I created a new ticket for the build status badge: https://app.clubhouse.io/pingthings-ws/story/13382/update-the-badge-for-build-status-in-btrdb-python-docs

Copy link

@looselycoupled looselycoupled left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mchestnut91 mchestnut91 merged commit 13e30ff into master May 26, 2021
@mchestnut91 mchestnut91 deleted the ch13150-modify-setup branch May 26, 2021 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants