-
Notifications
You must be signed in to change notification settings - Fork 2
modify setup and docs to use new repo #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This pull request has been linked to Clubhouse Story #13150: Modify setup.py, docs, etc. to use new repo. |
docs/source/conf.py
Outdated
@@ -26,8 +26,8 @@ | |||
# -- Project information ----------------------------------------------------- | |||
|
|||
project = 'btrdb' | |||
copyright = '2019, Michael P. Andersen' | |||
author = 'Michael P. Andersen' | |||
copyright = '2021, PingThingsIO' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pingthings here should be referred to as Ping Things, Inc.
- Note the space.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sounds good. Should I change it to that everywhere or just the copyright line?
You should also look at the following file for changes: https://github.com/PingThingsIO/btrdb-python/blob/master/docs/source/conf.py |
Also, perhaps a new ticket but the URL for the image/badge concerning build status is still pointing to travis and uses the wrong github repo. https://raw.githubusercontent.com/PingThingsIO/btrdb-python/master/docs/source/index.rst |
FYI I created a new ticket for the build status badge: https://app.clubhouse.io/pingthings-ws/story/13382/update-the-badge-for-build-status-in-btrdb-python-docs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR updates the setup.py file and the docs to reference the new repo. I believe these changes are sufficient for us to be able to use pypi with this repo, but we will need to test once we've done a new release