Skip to content

Optimizations in _parse_fh #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

dolmen
Copy link
Member

@dolmen dolmen commented Apr 9, 2014

Multiple small optimizations.

@karenetheridge
Copy link
Member

Thanks for this PR, and I will review it, but Module::Metadata is undergoing a near-complete rewrite right now, so performance optimizations are a bit premature and will need to be redone afterwards anyway :)

Thanks for the poke though, and I'll endeavour shortly to return to my work here that was being done at QAH.

@miyagawa
Copy link
Member

@dolmen looks like this PR is a bit controversial: guess you can make a separate PR for just utf-8'ing source code? 64d7abb

@dolmen
Copy link
Member Author

dolmen commented Apr 29, 2014

Summary of remaining commits to rework:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants