Skip to content

Deprecated slot special attributes, Use v-slot directives #238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 24, 2019
Merged

Deprecated slot special attributes, Use v-slot directives #238

merged 2 commits into from
May 24, 2019

Conversation

ycs77
Copy link
Contributor

@ycs77 ycs77 commented Apr 7, 2019

Vue.js deprecated slot special attributes after v2.6.0, it is recommended to use the v-slot directive.

Therefore, I made the following changes:

  1. Update Vue-Infinite-Loading's Vue.js version to v2.6.10 (current version)
  2. Change slot special attributes to v-slot directive in the documentation.

@ycs77 ycs77 marked this pull request as ready for review April 7, 2019 09:06
@codecov
Copy link

codecov bot commented Apr 7, 2019

Codecov Report

Merging #238 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #238   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           5      5           
  Lines         174    174           
  Branches       32     32           
=====================================
  Hits          174    174

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ccf1a20...9254d55. Read the comment docs.

@PeachScript
Copy link
Owner

PeachScript commented May 24, 2019

Sorry too late, I'm very busy in work recently :(

This is a very great and considerate PR, thank you very much! :D

@PeachScript PeachScript merged commit d8fd6c4 into PeachScript:master May 24, 2019
@PeachScript PeachScript mentioned this pull request May 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants