Skip to content

libssh 0.9.5 #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 27, 2020
Merged

libssh 0.9.5 #24

merged 4 commits into from
Sep 27, 2020

Conversation

enkore
Copy link
Member

@enkore enkore commented Sep 23, 2020 •
edited
Loading

Fixes #23

(eref 42d478fb6976)

@enkore
Copy link
Member Author

enkore commented Sep 23, 2020 •
edited
Loading

Building, installing & using a wheel locally works. As far as I can tell this doesn't change requirements (same CMake version etc.). Don't know what causes the CI failures, CircleCI unfortunately requests write access to all my repositories to let me look at the logs.

Edit: On another system I'm seeing an issue related to libssh_version.h not being found (weirdly this doesn't happen here), probably because it is now being generated through CMake and stored in the build directory.

Edit: Yep, was just missing the include directory. The system where it worked had a libssh installed in system directories, so the build found the libssh_version.h from the system.

Also confirmed that this fixes the libssh bug I encountered.

pkittenis
pkittenis requested changes Sep 23, 2020
View reviewed changes
Copy link
Member

@pkittenis pkittenis left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This check can now be removed - it was added for 0.9.4 and is causing build failures.

The libssh archive used for the manylinux builds will also need updating. It needs to be copied as docker cannot include files outside the dockerfile root dir.

@pkittenis
Copy link
Member

Thanks for raising! Comments above.

@enkore enkore force-pushed the libssh-0.9.5 branch 3 times, most recently from 4e7fc82 to 7965d96 Compare September 23, 2020 14:03
@enkore
Copy link
Member Author

enkore commented Sep 23, 2020 •
edited
Loading

Wheels seem to build correctly now. But it looks like I need to adjust Windows-settings as well.

@pkittenis pkittenis merged commit e0b0494 into ParallelSSH:master Sep 27, 2020
@enkore enkore deleted the libssh-0.9.5 branch September 28, 2020 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pkittenis pkittenis pkittenis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update to libssh 0.9.5
2 participants
@enkore @pkittenis