This repository was archived by the owner on Jan 2, 2019. It is now read-only.
Semantic table HTML reader #638
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces the new reader PHPExcel_Reader_HTML_SemanticTable. Compared to the existing HTML reader, SemanticTable doesn't try to convert everything table-looking. Instead only table elements are recognized and each is treated as a worksheet with the children elements caption, thead and tbody parsed as worksheet title, header rows and content rows respectively.
For example, the following HTML portion is recognized by SemanticTable:
To avoid repetitions in PHPExcel_Reader_HTML and PHPExcel_Reader_HTML_SemanticTable, an abstract base class is introduced which is used for common functionality. Care was taken to keep modifications in PHPExcel_Reader_HTML at a minimum, therefore it only uses defaultElementHandler and doesn't use TRAVERSE_CHILDS hint.