Skip to content
This repository was archived by the owner on Jan 2, 2019. It is now read-only.

When creating a chart 'displayBlanksAs' does not have any affect. #607

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions Classes/PHPExcel/Chart/Axis.php
Original file line number Diff line number Diff line change
Expand Up @@ -191,6 +191,11 @@ public function setAxisOptionsProperties($axis_labels, $horizontal_crosses_value
($minor_unit !== null) ? $this->axisOptions['minor_unit'] = (string) $minor_unit : null;
}

public function setAxisMaximum($maximum)
{
($maximum !== null) ? $this->axisOptions['maximum'] = (string) $maximum : null;
}

/**
* Get Axis Options Property
*
Expand Down
2 changes: 1 addition & 1 deletion Classes/PHPExcel/Writer/Excel2007/Chart.php
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ public function writeChart(PHPExcel_Chart $pChart = null)
$objWriter->endElement();

$objWriter->startElement('c:dispBlanksAs');
$objWriter->writeAttribute('val', "gap");
$objWriter->writeAttribute('val', $pChart->getDisplayBlanksAs());
$objWriter->endElement();

$objWriter->startElement('c:showDLblsOverMax');
Expand Down
2 changes: 1 addition & 1 deletion Examples/33chartcreate-area.php
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@
$legend, // legend
$plotArea, // plotArea
true, // plotVisibleOnly
0, // displayBlanksAs
'gap', // displayBlanksAs: gap, span, zero
NULL, // xAxisLabel
$yAxisLabel // yAxisLabel
);
Expand Down
2 changes: 1 addition & 1 deletion Examples/33chartcreate-bar-stacked.php
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@
$legend, // legend
$plotArea, // plotArea
true, // plotVisibleOnly
0, // displayBlanksAs
'gap', // displayBlanksAs: gap, span, zero
NULL, // xAxisLabel
$yAxisLabel // yAxisLabel
);
Expand Down
2 changes: 1 addition & 1 deletion Examples/33chartcreate-bar.php
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@
$legend, // legend
$plotArea, // plotArea
true, // plotVisibleOnly
0, // displayBlanksAs
'gap', // displayBlanksAs: gap, span, zero
NULL, // xAxisLabel
$yAxisLabel // yAxisLabel
);
Expand Down
2 changes: 1 addition & 1 deletion Examples/33chartcreate-column-2.php
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@
$legend, // legend
$plotArea, // plotArea
true, // plotVisibleOnly
0, // displayBlanksAs
'gap', // displayBlanksAs: gap, span, zero
$xAxisLabel, // xAxisLabel
$yAxisLabel // yAxisLabel
);
Expand Down
2 changes: 1 addition & 1 deletion Examples/33chartcreate-column.php
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@
$legend, // legend
$plotArea, // plotArea
true, // plotVisibleOnly
0, // displayBlanksAs
'gap', // displayBlanksAs: gap, span, zero
NULL, // xAxisLabel
$yAxisLabel // yAxisLabel
);
Expand Down
2 changes: 1 addition & 1 deletion Examples/33chartcreate-composite.php
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,7 @@
$legend, // legend
$plotArea, // plotArea
true, // plotVisibleOnly
0, // displayBlanksAs
'gap', // displayBlanksAs: gap, span, zero
NULL, // xAxisLabel
NULL // yAxisLabel
);
Expand Down
2 changes: 1 addition & 1 deletion Examples/33chartcreate-line.php
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@
$legend, // legend
$plotArea, // plotArea
true, // plotVisibleOnly
0, // displayBlanksAs
'gap', // displayBlanksAs: gap, span, zero
NULL, // xAxisLabel
$yAxisLabel // yAxisLabel
);
Expand Down
4 changes: 2 additions & 2 deletions Examples/33chartcreate-multiple-charts.php
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@
$legend1, // legend
$plotArea1, // plotArea
true, // plotVisibleOnly
0, // displayBlanksAs
'gap', // displayBlanksAs: gap, span, zero
NULL, // xAxisLabel
$yAxisLabel1 // yAxisLabel
);
Expand Down Expand Up @@ -191,7 +191,7 @@
$legend2, // legend
$plotArea2, // plotArea
true, // plotVisibleOnly
0, // displayBlanksAs
'gap', // displayBlanksAs: gap, span, zero
NULL, // xAxisLabel
$yAxisLabel2 // yAxisLabel
);
Expand Down
4 changes: 2 additions & 2 deletions Examples/33chartcreate-pie.php
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@
$legend1, // legend
$plotArea1, // plotArea
true, // plotVisibleOnly
0, // displayBlanksAs
'gap', // displayBlanksAs: gap, span, zero
NULL, // xAxisLabel
NULL // yAxisLabel - Pie charts don't have a Y-Axis
);
Expand Down Expand Up @@ -186,7 +186,7 @@
NULL, // legend
$plotArea2, // plotArea
true, // plotVisibleOnly
0, // displayBlanksAs
'gap', // displayBlanksAs: gap, span, zero
NULL, // xAxisLabel
NULL // yAxisLabel - Like Pie charts, Donut charts don't have a Y-Axis
);
Expand Down
2 changes: 1 addition & 1 deletion Examples/33chartcreate-radar.php
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@
$legend, // legend
$plotArea, // plotArea
true, // plotVisibleOnly
0, // displayBlanksAs
'gap', // displayBlanksAs: gap, span, zero
NULL, // xAxisLabel
NULL // yAxisLabel - Radar charts don't have a Y-Axis
);
Expand Down
2 changes: 1 addition & 1 deletion Examples/33chartcreate-scatter.php
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@
$legend, // legend
$plotArea, // plotArea
true, // plotVisibleOnly
0, // displayBlanksAs
'gap', // displayBlanksAs: gap, span, zero
NULL, // xAxisLabel
$yAxisLabel // yAxisLabel
);
Expand Down
2 changes: 1 addition & 1 deletion Examples/33chartcreate-stock.php
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@
$legend, // legend
$plotArea, // plotArea
true, // plotVisibleOnly
0, // displayBlanksAs
'gap', // displayBlanksAs: gap, span, zero
$xAxisLabel, // xAxisLabel
$yAxisLabel // yAxisLabel
);
Expand Down