Skip to content

Docs: various minor fixes #788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 23, 2025
Merged

Docs: various minor fixes #788

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Standards/Generic/Sniffs/NamingConventions/UpperCaseConstantNameSniff.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ public function process(File $phpcsFile, $stackPtr)
$constName = $tokens[$constPtr]['content'];
$prefix = '';

// Strip namespace from constant like /foo/bar/CONSTANT.
// Strip namespace from constant like \foo\bar\CONSTANT.
$splitPos = strrpos($constName, '\\');
if ($splitPos !== false) {
$prefix = substr($constName, 0, ($splitPos + 1));
Expand Down
2 changes: 1 addition & 1 deletion tests/Core/Ruleset/RuleInclusionTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -450,7 +450,7 @@ public function testSettingInvalidPropertiesOnStandardsAndCategoriesSilentlyFail
*
* @see self::testSettingInvalidPropertiesOnStandardsAndCategoriesSilentlyFails()
*
* @return array<string, array>string, string>>
* @return array<string, array<string, string>>
*/
public static function dataSettingInvalidPropertiesOnStandardsAndCategoriesSilentlyFails()
{
Expand Down
4 changes: 2 additions & 2 deletions tests/Core/Ruleset/ShowSniffDeprecationsTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,7 +256,7 @@ public function testDeprecatedSniffsListDoesNotShowWhenAllDeprecatedSniffsAreExc


/**
* Test deprecated sniffs are listed alphabetically in the deprecated sniffs warning.
* Test various aspects of the deprecated sniffs warning.
*
* This tests a number of different aspects:
* 1. That the summary line uses the correct grammar when there is are multiple deprecated sniffs.
Expand Down Expand Up @@ -321,7 +321,7 @@ public function testDeprecatedSniffsWarning()


/**
* Test deprecated sniffs are listed alphabetically in the deprecated sniffs warning.
* Test the report width is respected when displaying the deprecated sniffs warning.
*
* This tests the following aspects:
* 1. That the summary line uses the correct grammar when there is a single deprecated sniff.
Expand Down
Loading