Skip to content

Delete ChangeLog.md #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 20, 2018
Merged

Delete ChangeLog.md #10

merged 1 commit into from
Aug 20, 2018

Conversation

keradus
Copy link
Member

@keradus keradus commented Aug 17, 2018

Changelog is confusing only, it mention only one release, while there are few more.

Changelog is confusing only, it mention only one release, while there are few more.
@keradus keradus requested a review from a team August 17, 2018 07:15
@julienfalque
Copy link
Member

I would make it up-to-date rather than removing it.

@keradus
Copy link
Member Author

keradus commented Aug 17, 2018

that's the thing, nobody cares, either we, as ppl who release it, or users, as ppl who may want to have it. so why bother and spent time on it ?
(other thing, is that this package was release as internal one and is supposed to be used only by PHP CS Fixer v2 (v3 is already not using fork anymore)

Copy link
Member

@julienfalque julienfalque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(other thing, is that this package was release as internal one and is supposed to be used only by PHP CS Fixer v2 (v3 is already not using fork anymore)

Forgot that point, 👍 for removal

@SpacePossum SpacePossum merged commit bcefc95 into master Aug 20, 2018
@SpacePossum
Copy link

thanks @keradus , indeed nice to clean up to prevent confusion 👍

@keradus keradus deleted the keradus-patch-1 branch August 20, 2018 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants