This repository was archived by the owner on Jun 10, 2019. It is now read-only.
Disable boardcard animations for mobile. #830
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylemh
suggested changes
Jan 28, 2018
| @@ -63,3 +63,14 @@ | |||
| align-self: left; | |||
| padding: 1rem 0 0 0; | |||
| } | |||
|
|
|||
| @media screen and (max-width: 850px) { | |||
There was a problem hiding this comment.
This won't deactivate the animation.
You'll want to set transition: none on the classes and states involved (:hover, :active, etc).
Let's do it on devices under 450px in width instead of 850, also. The animations should work okay on tablets.
There was a problem hiding this comment.
Done. I appreciate the review feedback.
kylemh
approved these changes
Jan 30, 2018
src/scenes/home/team/team.js
Outdated
| @@ -31,6 +31,7 @@ class Team extends Component { | |||
|
|
|||
| const boardMembers = BoardMembers.map(boardMember => ( | |||
| <BoardCard | |||
| key={`${Math.random()} + ${boardMember.name}`} | |||
There was a problem hiding this comment.
It's a huge nitpick, but we can simply use ${boardMember.name} + ${boardMember.role} inside key to avoid a function call.
kylemh
approved these changes
Jan 30, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Disable boardcard height and opacity style for mobile (viewports less than 850px).
Issue Resolved
Fixes #829