Skip to content

Issue: #21334 Abstract PHP support of "original" for variableNamingConvention #21336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

aghajani
Copy link
Contributor

@aghajani aghajani commented May 27, 2025

Resolving #21334: Added the support for "original" value for "variableNamingConvention" option. When used it will not modify the names

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request. @jebentier (2017/07), @dkarlovi (2017/07), @mandrean (2017/08), @jfastnacht (2017/09), @ybelenko (2018/07), @renepardon (2018/12)

@aghajani
Copy link
Contributor Author

@wing328 if you know a reviewer :)

@wing328
Copy link
Member

wing328 commented May 28, 2025

thanks for the PR

what about naming the option as original (used in typescript and other generators) instead of off?

@aghajani
Copy link
Contributor Author

thanks for the PR

what about naming the option as original (used in typescript and other generators) instead of off?

Sure, if it is used in other places, why not, did the change and updated the PR

@aghajani
Copy link
Contributor Author

aghajani commented Jun 2, 2025

thanks for the PR
what about naming the option as original (used in typescript and other generators) instead of off?

Sure, if it is used in other places, why not, did the change and updated the PR

@wing328 once more? 😶‍🌫️

@aghajani aghajani changed the title Issue: #21334 Abstract PHP support of "off" for variableNamingConvention Issue: #21334 Abstract PHP support of "original" for variableNamingConvention Jun 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants