Skip to content

fix: #21329 Java Native, Provide Null Check before toString on param variables #21330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

duttonw
Copy link
Contributor

@duttonw duttonw commented May 26, 2025

Fixes #21329

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10) @martin-mfg (2023/08)

@wing328
Copy link
Member

wing328 commented May 26, 2025

thanks for the pr

please follow step 3 to update the samples so that ci can verify the change

let us know if you need any help

@duttonw
Copy link
Contributor Author

duttonw commented May 26, 2025

Hi @wing328 , running into proxy issues at work, will pick up when i get home to do the next steps.

@duttonw duttonw marked this pull request as ready for review May 26, 2025 03:11
@wing328 wing328 added Client: Java Issue: Bug Announcement Project/release related announcements labels Jun 2, 2025
@wing328 wing328 added this to the 7.14.0 milestone Jun 2, 2025
@wing328 wing328 removed the Announcement Project/release related announcements label Jun 2, 2025
@wing328 wing328 merged commit b929970 into OpenAPITools:master Jun 2, 2025
86 checks passed
@wing328
Copy link
Member

wing328 commented Jun 2, 2025

thanks for the pr, which has been merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG][java native] querystring Objects toString not checked if null prior
2 participants