-
-
Notifications
You must be signed in to change notification settings - Fork 7k
fix: update axum generated multipart requests to own the body #21301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update axum generated multipart requests to own the body #21301
Conversation
… Body Notes: &Multipart cannot access fields, as we need mutable access.
thanks for the PR please run |
@wing328 done, will push. Is there a test that will check that the servers compile and/or successfully produce multipart? |
Notes: Ran ./mvnw clean package || exit ./bin/generate-samples.sh ./bin/configs/*.yaml || exit ./bin/utils/export_docs_generators.sh || exit
Notes: Multipart should be owned; normal request remains borrowed
@@ -1 +1 @@ | |||
7.13.0-SNAPSHOT | |||
7.12.0-SNAPSHOT |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you please merge the latest master (upstream official) to your branch, build the CLI JAR locally and regenerate the samples again?
thanks for the PR cc @linxGnu |
let's give it a try thanks again for the PR |
This PR updates axum multipart requests (multipart and multipart-related) to give ownership of the multipart request contents to the application.
The following method on
Multipart
highlights the need:it requires
&mut
on the multipart argument to allow reading its contents.In axum documentation, multipart requests are implemented with full ownership (https://docs.rs/axum/latest/axum/extract/struct.Multipart.html).
Taken from the above link, please note the order of parameters is important:
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master
(upcoming7.x.0
minor release - breaking changes with fallbacks),8.0.x
(breaking changes without fallbacks)