-
Notifications
You must be signed in to change notification settings - Fork 107
Added code generation for OnXyz and SendXyz methods (1/2) #256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
TLDR: I'm sick of trying to keep all the methods in sync, but want to offer both an interface and delegate based interface for every handler. This solves that since handlers follow a fairly common pattern. |
Codecov Report
@@ Coverage Diff @@
## master #256 +/- ##
==========================================
+ Coverage 62.06% 62.07% +0.01%
==========================================
Files 383 387 +4
Lines 11489 12605 +1116
Branches 1361 1456 +95
==========================================
+ Hits 7131 7825 +694
- Misses 3788 4178 +390
- Partials 570 602 +32
Continue to review full report at Codecov.
|
Really cool idea! First seeing source generators in action. How was the dev experience with em? |
@NTaylorMullen I was actually pretty pleased with it. I have not played with the latest source generators but I assume they would be fairly similar. Sometimes I'd break things literally in half, break the generator, and using generated methods and things fall apart fast... however that's what unit tests are for. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't really judge the generator code cause I don't have the domain expertise, but I'm so excited to have all the On/Send messages available.
This is part one that only includes a few file changes to make the objective a little clearer. the next is just a bunch of deleted code (yay deleted code! 🥳 )