v3.1.2: Clarify that Request Body Objects need a body #4614
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We require `content` but failed to require it to be non-empty, even though a request body without a body does not make any sense.
handrews
added
clarification
miqui
previously approved these changes
May 18, 2025
Co-authored-by: Ralf Handl <ralf.handl@sap.com>
ralfhandl
approved these changes
May 19, 2025
|
I'm going to merge this as @miqui 's approval only got dropped b/c of a typo fix. So there are two TSC approvals here. |
|
Note- I will batch up the recent 3.1.2 PRs into a single 3.2 sync PR to avoid too much noise in the PR list. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes:
We require the Request Body Object's
contentbut failed to require it to be non-empty, even though a request body without a body does not make any sense.