Skip to content

v3.2: Allow allowReserved everywhere #4593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: v3.2-dev
Choose a base branch
from

Conversation

handrews
Copy link
Member

Fixes:

The restriction on allowReserved make some useful configurations impossible, and do not actually prevent pathological scenarios like path parameter values containing /, from occurring. Such pathological scenarios are already possible by using content instead of style/explode/allowReserved.

Lifting the restriction also makes the handling of this field more consistent, as it is no longer necessary to keep track of the destination.

  • schema changes are included in this pull request
  • schema changes are needed for this pull request but not done yet
  • no schema changes are needed for this pull request

The restriction on `allowReserved` make some useful configurations
impossible, and do not actually prevent pathological scenarios
like path parameter values containing `/`, from occurring.  Such
pathological scenarios are already possible by using `content`
instead of `style`/`explode`/`allowReserved`.

Lifting the restriction also makes the handling of this field
more consistent.
@handrews handrews added this to the v3.2.0 milestone May 16, 2025
@handrews handrews requested review from a team as code owners May 16, 2025 01:43
@handrews handrews added param serialization Issues related to parameter and/or header serialization media and encoding Issues regarding media type support and how to encode data (outside of query/path params) labels May 16, 2025
Copy link
Contributor

@ralfhandl ralfhandl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, just one typo

@ralfhandl ralfhandl requested a review from a team May 16, 2025 17:23
Co-authored-by: Ralf Handl <ralf.handl@sap.com>
@ralfhandl ralfhandl requested a review from a team May 18, 2025 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
media and encoding Issues regarding media type support and how to encode data (outside of query/path params) param serialization Issues related to parameter and/or header serialization
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants