Fix for Bug: xread in cluster mode calculates slots on wrong arguments #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BridgeAR
reviewed
May 8, 2019
|
I think this is solved here: #31 |
|
@voraparth91 thanks a lot for your contribution! This has been superseded by #31. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example command: XREAD COUNT 2 STREAMS mystream writers 0-0 0-0
In this case, it should calculate slot on mystream and writers while it calculates on 'COUNT'. This is a bug in case of cluster mode.
Solution: now xread is considered a special case where we find all the streams name that are after keyword: STREAMS till ID starts.