Fix path/name quotation #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0.6.4 has some unresolved issues which disallow running unit tests for this project
| @@ -719,6 +719,9 @@ function pbxFileReferenceObj(file) { | |||
|
|
|||
| if(!file.basename.match(/^[a-zA-Z0-9_\.\$]+\.[a-zA-Z]+$/)) { | |||
| obj.name = "\"" + obj.name + "\""; | |||
| } | |||
|
|
|||
| if(!file.path.match(/^[a-zA-Z0-9_\.\$]+\.[a-zA-Z]+$/)) { | |||
There was a problem hiding this comment.
You can extract the regex to separate variable.
|
👍 |
Those properties should be surrounded by quotation marks based on appearance of special characters in path and basename properties respectively. They are independent of one another.
Mitko-Kerezov
force-pushed
the
kerezov/fix-path-name-quotation
branch
from
9904125 to
f879ed0
Compare
|
Addressed comments by @Fatme |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Those properties should be surrounded by quotation marks based on appearance of special characters in path and basename properties respectively.
They are independent of one another.
Includes unit tests as well as a newer nodeunit version as a dev dependency.
Ping @Fatme