Skip to content

chore: update app's to latest 8 rc version of Angular #378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 30, 2019
Merged

chore: update app's to latest 8 rc version of Angular #378

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c6d8003
chore: update app's to latest 8 rc version of Angular
May 21, 2019
0cd5396
chore: upgrade to rc5
May 27, 2019
1b520be
chore: update breaking changes from Angular 8 rc5
May 27, 2019
710eb1f
chore: update example to work with new `ViewChild` behavior of Angular 8
May 28, 2019
27eb5f7
chore: update to Angular 8.0.0
May 29, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...reens-category/content-screens/content-scrollable/content-scrollable-example.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@ export class ContentScrollablePageExampleComponent implements OnInit {
public image: Image;
public flex: FlexboxLayout;

@ViewChild("img") img: ElementRef;
@ViewChild("content") content: ElementRef;
@ViewChild("img", { read: ElementRef, static: false }) img: ElementRef;
@ViewChild("content", { read: ElementRef, static: false }) content: ElementRef;

constructor(public page: Page) {
this.page.backgroundSpanUnderStatusBar = true;
Expand Down
2 changes: 1 addition & 1 deletion app/ng-ui-category/modal-view-ng/sample-modal-view-module-example/modal-view.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import { DatePicker } from "tns-core-modules/ui/date-picker";
})
export class ModalViewComponent implements OnInit {
public currentdate: Date;
@ViewChild("datepicker") datePickerElement: ElementRef;
@ViewChild("datepicker", { read: ElementRef, static: true }) datePickerElement: ElementRef;

constructor(private params: ModalDialogParams) {
this.currentdate = new Date(params.context);
Expand Down
6 changes: 3 additions & 3 deletions app/ng-ui-widgets-category/web-view/basic-web-view/basic-web-view.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,9 @@ import { Label } from "tns-core-modules/ui/label";
export class BasicWebViewComponent implements AfterViewInit {
public webViewSrc: string = "https://docs.nativescript.org/";
public enabled: boolean = false;
@ViewChild("myWebView") webViewRef: ElementRef;
@ViewChild("urlField") urlFieldRef: ElementRef;
@ViewChild("labelResult") labelResultRef: ElementRef;
@ViewChild("myWebView", { read: ElementRef, static: false }) webViewRef: ElementRef;
@ViewChild("urlField", { read: ElementRef, static: false }) urlFieldRef: ElementRef;
@ViewChild("labelResult", { read: ElementRef, static: false }) labelResultRef: ElementRef;

ngAfterViewInit() {
let webview: WebView = this.webViewRef.nativeElement;
Expand Down
2 changes: 1 addition & 1 deletion app/ng-ui-widgets-category/web-view/events/web-view-events.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ export class WebViewEventsComponent {
public webViewSrc = "https://docs.nativescript.org/";
public isItemVisible = true;

@ViewChild("webview") webViewElement: ElementRef;
@ViewChild("webview", { read: ElementRef, static: false }) webViewElement: ElementRef;
private firstUrl = "https://google.com/";
private secondUrl = "https://docs.nativescript.org/";

Expand Down
22 changes: 11 additions & 11 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,14 +29,14 @@
}
},
"dependencies": {
"@angular/common": "~7.2.0",
"@angular/compiler": "~7.2.0",
"@angular/core": "~7.2.0",
"@angular/forms": "~7.2.0",
"@angular/http": "~7.2.0",
"@angular/platform-browser": "~7.2.0",
"@angular/platform-browser-dynamic": "~7.2.0",
"@angular/router": "~7.2.0",
"@angular/common": "8.0.0",
"@angular/compiler": "8.0.0",
"@angular/core": "8.0.0",
"@angular/forms": "8.0.0",
"@angular/http": "8.0.0-beta.10",
"@angular/platform-browser": "8.0.0",
"@angular/platform-browser-dynamic": "8.0.0",
"@angular/router": "8.0.0",
"nativescript-angular": "next",
"nativescript-camera": "^4.4.0",
"nativescript-geolocation": "^5.0.0",
Expand All @@ -48,8 +48,8 @@
"zone.js": "^0.8.4"
},
"devDependencies": {
"@angular/compiler-cli": "~7.2.0",
"@ngtools/webpack": "~7.2.0",
"@angular/compiler-cli": "8.0.0",
"@ngtools/webpack": "8.0.0",
"codelyzer": "^3.0.1",
"fs-extra": "^0.30.0",
"glob": "^7.1.3",
Expand All @@ -62,7 +62,7 @@
"tar.gz": "^1.0.5",
"tns-platform-declarations": "next",
"tslint": "^5.11.0",
"typescript": "~3.1.1"
"typescript": "~3.4.5"
},
"scripts": {
"pretsc": "npm install",
Expand Down