'npm run clean' causes subsequent runs to fail

[NathanWalker]

Not sure what cause is. First time I had began a new plugin in awhile from this seed and was sad it failed.

executing 'tns plugin build'
npm WARN demo No description
npm WARN demo No repository field.
npm WARN demo No license field.

npm ERR! path /Users/nathan/Documents/github/nstudio/nativescript-jumio/demo/node_modules/.staging/@nstudio/nativescript-jumio-04edbcf5/node_modules/ansi-regex
npm ERR! code ENOENT
npm ERR! errno -2
npm ERR! syscall rename
npm ERR! enoent ENOENT: no such file or directory, rename '/Users/nathan/Documents/github/nstudio/nativescript-jumio/demo/node_modules/.staging/@nstudio/nativescript-jumio-04edbcf5/node_modules/ansi-regex' -> '/Users/nathan/Documents/github/nstudio/nativescript-jumio/demo/node_modules/.staging/ansi-regex-548e4059'
npm ERR! enoent This is related to npm not being able to find a file.

I'll try to investigate later and submit PR if I can figure out what's going on.

[NathanWalker]

https://docs.nativescript.org/tooling/docs-cli/lib-management/plugin-build
Why is tns plugin build part of the default setup in this seed even if not using Android specific files? Could it be cause to the error?

[NathanWalker]

This could be related to usage of scoped package name. Reporting as I investigate more here.

[NathanWalker]

Ok so turns out if you were to clear the demo app (aka, clean it with cd demo; rm -rf hooks node_modules platforms) then go into src and npm run demo.ios causes this issue.

Resolution appears to be to run npm run plugin.link if you were to clean the demo.

Do we really need thisnpm link business?

[NathanWalker]

Ok I have a repro - seems to be related to npm run clean.

git clone https://github.com/NativeScript/nativescript-plugin-seed nativescript-sampleplugin
cd nativescript-sampleplugin/src
npm run postclone
// fill out details (doesn't matter what you input)
npm run demo.ios
// this will run fine
// now stop the run
npm run clean
npm run demo.ios
// this will now fail

Nathans-MacBook-Pro:tmp nathan$ git clone https://github.com/NativeScript/nativescript-plugin-seed nativescript-sampleplugin
Cloning into 'nativescript-sampleplugin'...
remote: Counting objects: 1519, done.
remote: Compressing objects: 100% (16/16), done.
remote: Total 1519 (delta 9), reused 12 (delta 5), pack-reused 1498
Receiving objects: 100% (1519/1519), 2.67 MiB | 6.44 MiB/s, done.
Resolving deltas: 100% (833/833), done.
Nathans-MacBook-Pro:tmp nathan$ cd nativescript-sampleplugin/
Nathans-MacBook-Pro:nativescript-sampleplugin nathan$ cd src
Nathans-MacBook-Pro:src nathan$ npm run postclone

> nativescript-yourplugin@1.0.0 postclone /Users/nathan/Documents/github/nstudio/tmp/nativescript-sampleplugin/src
> npm i && node scripts/postclone.js && cd ../demo && npm i

npm notice created a lockfile as package-lock.json. You should commit this file.
npm WARN nativescript-yourplugin@1.0.0 No repository field.

added 66 packages from 34 contributors and audited 106 packages in 4.217s
found 0 vulnerabilities

NativeScript Plugin Seed Configuration
prompt: What is your GitHub username (used for updating package.json)? Example: NathanWalker / EddyVerbruggen:  NathanWalker
prompt: What will be the name of your plugin? Use lowercase characters and dashes only. Example: yourplugin / google-maps / bluetooth:  sampleplugin
Using Sampleplugin as the TypeScript Class name..
Will now rename some files..
Adjusting scripts..
Screenshots removed.
Seed tests removed.
prompt: Do you want to init a fresh local git project? If you previously 'git clone'd this repo that would be wise (y/n):  (y) y
Configuration finished! If you're not happy with the result please clone the seed again and rerun this script.
You can now continue by running 'npm run plugin.tscwatch' in this window and in another one - 'npm run demo.ios' or 'npm run demo.android'!
npm WARN deprecated babel-preset-es2015@6.24.1: 🙌  Thanks for using Babel: we recommend using babel-preset-env now: please read babeljs.io/env to update! 
npm WARN deprecated nomnom@1.8.1: Package no longer supported. Contact support@npmjs.com for more info.

> fsevents@1.2.4 install /Users/nathan/Documents/github/nstudio/tmp/nativescript-sampleplugin/demo/node_modules/fsevents
> node install

[fsevents] Success: "/Users/nathan/Documents/github/nstudio/tmp/nativescript-sampleplugin/demo/node_modules/fsevents/lib/binding/Release/node-v64-darwin-x64/fse.node" already installed
Pass --update-binary to reinstall or --build-from-source to recompile

> nativescript-dev-typescript@0.7.2 postinstall /Users/nathan/Documents/github/nstudio/tmp/nativescript-sampleplugin/demo/node_modules/nativescript-dev-typescript
> node postinstall.js

Adding 'es6' lib to tsconfig.json...
Adding 'dom' lib to tsconfig.json...
Adding tns-core-modules path mappings lib to tsconfig.json...
Project already targets TypeScript ~2.8.2

> nativescript-dev-webpack@0.15.1 postinstall /Users/nathan/Documents/github/nstudio/tmp/nativescript-sampleplugin/demo/node_modules/nativescript-dev-webpack
> node postinstall.js

Creating file: /Users/nathan/Documents/github/nstudio/tmp/nativescript-sampleplugin/demo/webpack.config.js
Creating file: /Users/nathan/Documents/github/nstudio/tmp/nativescript-sampleplugin/demo/tsconfig.esm.json

NativeScript Webpack plugin was successfully added.
You can now bundle your project by passing --bundle flag to NativeScript CLI commands:
    - tns build android --bundle
    - tns build ios --bundle
    - tns run android --bundle
    - tns run ios --bundle
You can also pass the "--env.uglify" flag to use UglifyJS for minification.
For more information check out https://docs.nativescript.org/tooling/bundling-with-webpack#bundling.


> nativescript-unit-test-runner@0.3.4 postinstall /Users/nathan/Documents/github/nstudio/tmp/nativescript-sampleplugin/demo/node_modules/nativescript-unit-test-runner
> node postinstall.js

npm notice created a lockfile as package-lock.json. You should commit this file.
npm WARN extract-text-webpack-plugin@3.0.2 requires a peer of webpack@^3.1.0 but none is installed. You must install peer dependencies yourself.
npm WARN demo No description
npm WARN demo No repository field.
npm WARN demo No license field.

added 1368 packages from 1036 contributors and audited 15721 packages in 46.03s
found 12 vulnerabilities (9 low, 3 high)
  run `npm audit fix` to fix them, or `npm audit` for details
Nathans-MacBook-Pro:src nathan$ code .
Nathans-MacBook-Pro:src nathan$ npm run demo.ios

> nativescript-sampleplugin@1.0.0 demo.ios /Users/nathan/Documents/github/nstudio/tmp/nativescript-sampleplugin/src
> npm i && npm run tsc && cd ../demo && tns run ios --syncAllFiles

npm WARN nativescript-sampleplugin@1.0.0 No repository field.

audited 106 packages in 1.855s
found 0 vulnerabilities


> nativescript-sampleplugin@1.0.0 tsc /Users/nathan/Documents/github/nstudio/tmp/nativescript-sampleplugin/src
> tsc -skipLibCheck

Searching for devices...

// xcode build truncated here for issue posting

Project successfully prepared (iOS)
Executing after-prepare hook from /Users/nathan/Documents/github/nstudio/tmp/nativescript-sampleplugin/demo/hooks/after-prepare/nativescript-dev-webpack.js
Executing after-prepare hook from /Users/nathan/Documents/github/nstudio/tmp/nativescript-sampleplugin/demo/hooks/after-prepare/nativescript-unit-test-runner.js
Successfully transferred sampleplugin.ts.
Successfully transferred sampleplugin.js.
Refreshing application...
Successfully synced application org.nativescript.demo on device 1BA43BE4-868E-458F-8390-DEB7C3AFE1BD.
CONSOLE LOG file:///app/tns_modules/nativescript-sampleplugin/sampleplugin.js:8:20: typeof FreshchatConfig: undefined
CONSOLE LOG Dialog closed.
^CExecuting after-watch hook from /Users/nathan/Documents/github/nstudio/tmp/nativescript-sampleplugin/demo/hooks/after-watch/nativescript-dev-typescript.js
Stopping tsc watch
Executing after-watch hook from /Users/nathan/Documents/github/nstudio/tmp/nativescript-sampleplugin/demo/hooks/after-watch/nativescript-dev-webpack.js
Child process terminated with signal 2: Interrupt
Executing after-watch hook from /Users/nathan/Documents/github/nstudio/tmp/nativescript-sampleplugin/demo/hooks/after-watch/nativescript-dev-typescript.js
Executing after-watch hook from /Users/nathan/Documents/github/nstudio/tmp/nativescript-sampleplugin/demo/hooks/after-watch/nativescript-dev-webpack.js
Nathans-MacBook-Pro:src nathan$ 
Nathans-MacBook-Pro:src nathan$ npm run clean

> nativescript-sampleplugin@1.0.0 clean /Users/nathan/Documents/github/nstudio/tmp/nativescript-sampleplugin/src
> cd ../demo && rimraf hooks node_modules platforms && cd ../src && rimraf node_modules

Nathans-MacBook-Pro:src nathan$ npm run demo.ios

> nativescript-sampleplugin@1.0.0 demo.ios /Users/nathan/Documents/github/nstudio/tmp/nativescript-sampleplugin/src
> npm i && npm run tsc && cd ../demo && tns run ios --syncAllFiles

npm WARN nativescript-sampleplugin@1.0.0 No repository field.

added 66 packages from 34 contributors and audited 106 packages in 1.891s
found 0 vulnerabilities


> nativescript-sampleplugin@1.0.0 tsc /Users/nathan/Documents/github/nstudio/tmp/nativescript-sampleplugin/src
> tsc -skipLibCheck

Searching for devices...

> nativescript-sampleplugin@1.0.0 prepack /Users/nathan/Documents/github/nstudio/tmp/nativescript-sampleplugin/src
> npm run build.native


> nativescript-sampleplugin@1.0.0 build.native /Users/nathan/Documents/github/nstudio/tmp/nativescript-sampleplugin/src
> node scripts/build-native.js

executing 'tns plugin build'
npm WARN demo No description
npm WARN demo No repository field.
npm WARN demo No license field.

npm ERR! path /Users/nathan/Documents/github/nstudio/tmp/nativescript-sampleplugin/demo/node_modules/.staging/nativescript-sampleplugin-3ecaa2ed/node_modules/ansi-regex
npm ERR! code ENOENT
npm ERR! errno -2
npm ERR! syscall rename
npm ERR! enoent ENOENT: no such file or directory, rename '/Users/nathan/Documents/github/nstudio/tmp/nativescript-sampleplugin/demo/node_modules/.staging/nativescript-sampleplugin-3ecaa2ed/node_modules/ansi-regex' -> '/Users/nathan/Documents/github/nstudio/tmp/nativescript-sampleplugin/demo/node_modules/.staging/ansi-regex-85e07359'
npm ERR! enoent This is related to npm not being able to find a file.
npm ERR! enoent 

npm ERR! A complete log of this run can be found in:
npm ERR!     /Users/nathan/.npm/_logs/2018-08-20T17_05_57_588Z-debug.log
Command npm install failed with exit code 254
# tns run ios

┌────────────────────────────────────────────────────────────────────────────────────────────┬───────────────────────────────────────────────────────────────────┐
│ Usage                                                                                      │ Synopsis                                                          │
│ Run on all connected devices                                                               │ $ tns run ios [--release] [--justlaunch] [--bundle [<value>] [-   │
│                                                                                            │ -env.*]]                                                          │
│ Run on a selected connected device. Will start simulator with specified Device Identifier  │ $ tns run ios [--device <Device ID>] [--release] [--justlaunch] [ │
│ or Device Name, if not already running.                                                    │ --bundle [<value>] [--env.*]]                                     │
│ Start an emulator and run the app inside it                                                │ $ tns run ios --emulator [--release] [--bundle [<value>] [--env.* │
│                                                                                            │ ]]                                                                │
│ Start an emulator with specified device name and sdk                                       │ $ tns run ios [--device <Device Name>] [--sdk <sdk>]              │
│ Start an emulator with specified device identifier and sdk                                 │ $ tns run ios [--device <Device Identifier>] [--sdk <sdk>]        │
└────────────────────────────────────────────────────────────────────────────────────────────┴───────────────────────────────────────────────────────────────────┘

Runs your project on a connected iOS device or in the iOS Simulator, if configured. This is shorthand for prepare, build and deploy. While your app is running, prints the output from the application in the console and watches for changes in your code. Once a change is detected, it synchronizes the change with all selected devices and restarts/refreshes the application.

IMPORTANT: Before building for iOS device, verify that you have configured a valid pair of certificate and provisioning profile on your OS X system. 

### Options

    * --device - Specifies a connected device/simulator to start and run the app.
    * --emulator - If set, runs the app in all available and configured ios simulators. It will start a simulator if none are already running.
    * --sdk - Specifies the target simulator's sdk.
    * --justlaunch - If set, does not print the application output in the console.
    * --clean - If set, forces rebuilding the native application.
    * --no-watch - If set, changes in your code will not be reflected during the execution of this command.
    * --release - If set, produces a release build. Otherwise, produces a debug build.
    * --bundle - Specifies that a bundler (e.g. webpack) should be used if one is present. If no value is passed will default to webpack.
    * --env.* - Specifies additional flags that the bundler may process. May be passed multiple times. For example: --env.uglify --env.snapshot.
    * --syncAllFiles - Watches all production dependencies inside node_modules for changes. Triggers project rebuild if necessary!

### Attributes

    * <Device ID> is the index or Device Identifier of the target device as listed by $ tns device ios --available-devices
    * <Device Name> is the name of the target simulator as listed by $ tns device ios --available-devices

npm ERR! file sh
npm ERR! code ELIFECYCLE
npm ERR! errno ENOENT
npm ERR! syscall spawn
npm ERR! nativescript-sampleplugin@1.0.0 demo.ios: `npm i && npm run tsc && cd ../demo && tns run ios --syncAllFiles`
npm ERR! spawn ENOENT
npm ERR! 
npm ERR! Failed at the nativescript-sampleplugin@1.0.0 demo.ios script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /Users/nathan/.npm/_logs/2018-08-20T17_05_57_697Z-debug.log

/cc @vakrilov

[lini]

Thanks for the steps. Unfortunately I am not able to reproduce the issue on my Mac. The application starts up normally both times. I am using the following configuration:

• macOS 10.13.6
• Xcode 9.4.1
• node v8.9.1
• npm 6.4.0
• tns 4.2.2
• app deployed on Iphone X with iOS 11.4.1

I searched a bit about the specific error you are getting and it seems that it happens only on some npm versions and there are several ways to try and fix it:

• update your npm version to a newer one
• do a npm cache clean --force
• if the above command does not work for some reason, try clearing the cache manually by first running npm config get cache to see where it is and then cleaning out the directory using rm -rf
• finally see if there are any leftover package-lock.json or npm-shinkwrap.json files in the cloned seed repo and remove them to get a fresh set of dependencies

Looking through the NPM repo, I can see multiple issues relating to the error:

• ENOENT errors, .staging? npm/npm#13528
• npm causes ENOENT in .staging, possibly related to bundled packages npm/npm#20119

[NathanWalker]

Excellent good to know this is purely node/npm 👍
We can probably add an additional hook into the npm script to clear the package-lock.json as that may be the solution for all node versions. I'll investigate if in fact that fixes for all here.
Obviously a lot of folks are on node v10+ (as am I) so the state of the seed right now does not work for node 10+. (as appears you attempted to repro in very confined 1 single use case).

[NathanWalker]

@lini the above pr solves for all node versions 👍