Skip to content

Simplify styling #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 27, 2019
Merged

Simplify styling #10

merged 6 commits into from
Mar 27, 2019

Conversation

bundyo
Copy link
Contributor

@bundyo bundyo commented Mar 21, 2019

  • Add PickerField element selector
  • Add PickerPage element that inherits from Page in the modal and a selector for it
  • Move the class set on ActionBar and ListView to the aforementioned PickerPage
  • Document it

PR Checklist

What is the current behavior?

Currently the PickerField inherits all TextField styling, but cannot be targeted in CSS with an element selector. In addition, currently the modal page elements can be only targeted with a class set on the PickerField which gets transferred on the ActionBar and ListView. We need a way to directly style all instances of PickeField modals without the need to set a class.

What is the new behavior?

PickerField element selector directly targets the element. A new element selector PickerPage is set on the modal, which can be used to target the ActionBar and ListView in it. Also the class is now set on the PickerPage, instead on the elements in it.

Closes #11.

BREAKING CHANGES:

  • Moves the classes from the ActionBar and ListView to the PickerPage element

Migration:

  • Fix selectors from ListView.class to .class ListView.

Add PickerPage element that inherits from Page in the modal and a selector for it
Move the class set on ActionBar and ListView to the aforementioned PickerPage
Document it
@cla-bot cla-bot bot added the cla: yes label Mar 21, 2019
@ghost ghost assigned bundyo Mar 21, 2019
@ghost ghost added the new PR label Mar 21, 2019
Copy link
Contributor

@VladimirAmiorkov VladimirAmiorkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great PR, all is left is to update the demo, demo-angular and demo-vue with the breaking changes.

bundyo added 2 commits March 22, 2019 16:23
Fix scoped styling in both Angular and Vue
Fix picker accessors
@VladimirAmiorkov VladimirAmiorkov force-pushed the bundev/simplify-styling branch from 69e9046 to eda993c Compare March 25, 2019 12:11
@NativeScript NativeScript deleted a comment from bundyo Mar 26, 2019
@ghost ghost assigned DimitarTodorov Mar 26, 2019
@VladimirAmiorkov VladimirAmiorkov merged commit 9ec34e3 into master Mar 27, 2019
@ghost ghost removed the new PR label Mar 27, 2019
@VladimirAmiorkov VladimirAmiorkov deleted the bundev/simplify-styling branch March 27, 2019 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants