This repository was archived by the owner on Aug 7, 2021. It is now read-only.
fix: bundle emitted on save without changes #1097
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
test cli-smoke cli-templates |
|
Can you please update the commit message to explain in details what's the change and why it is required? |
When there are no changes (timestamps are not modified) the chunk is taken from the cache. The cached asset object has the property existsAt set and this will prevent the emit of that chunk - https://github.com/webpack/webpack/blob/4056506488c1e071dfc9a0127daa61bf531170bf/lib/Compiler.js#L326. However when we replace the whole asset, the flag is no longer set and the chunk is emmited every time.
KristianDD
force-pushed
the
kddimitrov/fix-bundle-emit-empty-save
branch
from
54ee1d0 to
2d01df9
Compare
rosen-vladimirov
approved these changes
Nov 19, 2019
|
test cli-templates cli-run |
|
test cli-run |
2 similar comments
|
test cli-run |
|
test cli-run |
Fatme
approved these changes
Nov 21, 2019
|
test cli-run |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
What is the new behavior?
Fixes/Implements/Closes #1096