This repository was archived by the owner on Aug 7, 2021. It is now read-only.
fix: remove tns-core-modules dependency in order to allow @nativescrip/core migration #1091
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…scrip/core migration The parse method content is the same: Old: https://github.com/NativeScript/NativeScript/blob/fc2a233e9598def50969247c1516c32260b7e283/nativescript-core/css/lib/parse/index.js New: https://github.com/reworkcss/css/blob/v2.2.1/lib/parse/index.js
rosen-vladimirov
approved these changes
Nov 8, 2019
|
test webpack-apps cli-smoke |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
The plugin depends on
tns-core-modules.What is the new behavior?
The plugin does not depend on
tns-core-modules.P.S. This PR should not change anything in the business logic as the parse method content is the same.
Old:
https://github.com/NativeScript/NativeScript/blob/fc2a233e9598def50969247c1516c32260b7e283/nativescript-core/css/lib/parse/index.js
New:
https://github.com/reworkcss/css/blob/v2.2.1/lib/parse/index.js
Related to: #1089