Skip to content
This repository was archived by the owner on Aug 7, 2021. It is now read-only.
This repository was archived by the owner on Aug 7, 2021. It is now read-only.

First change in an application causes a restart #956

Open
@vchimev

Description

@vchimev

Describe the bug

The first change in an application with linked tns-core-modules causes a restart. It is caused by an unaccepted module, which weirdly bubbled up to the app.ts file.

To Reproduce

git clone git@github.com:NativeScript/NativeScript.git && cd NativeScript && npm install
cd e2e/ui-tests-app
tns run android|ios
  • make a change in the app/main-page.xml file

Expected behavior
Module app/main-page.xml to be accepted and applied without application restart.

CONSOLE INFO file:///node_modules/nativescript-dev-webpack/hot.js:3:0 HMR: Checking for updates to the bundle with hmr hash 33005837ebf5fe211c54.
CONSOLE INFO file:///node_modules/nativescript-dev-webpack/hot.js:3:0 HMR: The following modules were updated:
CONSOLE INFO file:///node_modules/nativescript-dev-webpack/hot.js:3:0 HMR:          ↻ ./main-page.xml
CONSOLE INFO file:///node_modules/nativescript-dev-webpack/hot.js:3:0 HMR: Successfully applied update with hmr hash 33005837ebf5fe211c54. App is up to date.

Additional context

Log:

CONSOLE INFO file:///node_modules/nativescript-dev-webpack/hot.js:3:0 HMR: Checking for updates to the bundle with hmr hash 15587a2491e51054ece2.
CONSOLE WARN file:///node_modules/nativescript-dev-webpack/hot.js:4:0 HMR: Ignored an update to unaccepted module:
CONSOLE WARN file:///node_modules/nativescript-dev-webpack/hot.js:4:0 HMR:          ➭ ../../../tns-core-modules/image-source/image-source.ts
CONSOLE WARN file:///node_modules/nativescript-dev-webpack/hot.js:4:0 HMR:          ➭ ../../../tns-core-modules/ui/action-bar/action-bar.ts
CONSOLE WARN file:///node_modules/nativescript-dev-webpack/hot.js:4:0 HMR:          ➭ ../../../tns-core-modules/ui/page/page-common.ts
CONSOLE WARN file:///node_modules/nativescript-dev-webpack/hot.js:4:0 HMR:          ➭ ../../../tns-core-modules/ui/page/page.ts
CONSOLE WARN file:///node_modules/nativescript-dev-webpack/hot.js:4:0 HMR:          ➭ ../../../tns-core-modules/bundle-entry-points.ts
CONSOLE WARN file:///node_modules/nativescript-dev-webpack/hot.js:4:0 HMR:          ➭ ./app.ts
CONSOLE ERROR file:///node_modules/nativescript-dev-webpack/hot.js:5:0 HMR: Cannot apply update with hmr hash 15587a2491e51054ece2.
CONSOLE ERROR file:///node_modules/nativescript-dev-webpack/hot.js:5:0 HMR: Aborted because ../../../tns-core-modules/image-source/image-source.ts is not accepted

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions