tslint related changes

Gruntfile.js

@@ -55,9 +55,20 @@ module.exports = function(grunt) {
 					sourceMap: false,
 					removeComments: true
 				}
-			}
+			},
 		},
-
+
+		tslint: {
+            build: {
+                files: {
+                    src: ["lib/**/*.ts", "test/**/*.ts", "!lib/common/node_modules/**/*.ts", "lib/common/test/unit-tests/**/*.ts", "definitions/**/*.ts", "!**/*.d.ts"]
+                },
+                options: {
+                    configuration: grunt.file.readJSON("./tslint.json")
+                }
+            }
+        },
+
 		watch: {
 			devall: {
 				files: ["lib/**/*.ts", 'test/**/*.ts', "!lib/common/node_modules/**/*.ts"],
@@ -119,9 +130,9 @@ module.exports = function(grunt) {
 	grunt.loadNpmTasks("grunt-contrib-watch");
 	grunt.loadNpmTasks("grunt-shell");
 	grunt.loadNpmTasks("grunt-ts");
+	grunt.loadNpmTasks("grunt-tslint");
 
 	grunt.registerTask("set_package_version", function(version) {
-		var fs = require("fs");
 		var buildVersion = version !== undefined ? version : buildNumber;
 		if (process.env["BUILD_CAUSE_GHPRBCAUSE"]) {
 			buildVersion = "PR" + buildVersion;
@@ -150,7 +161,6 @@ module.exports = function(grunt) {
 		grunt.file.write("package.json", JSON.stringify(packageJson, null, "  "));
 	});
 
-
 	grunt.registerTask("test", ["ts:devall", "shell:npm_test"]);
 	grunt.registerTask("pack", [
 		"clean",
@@ -162,6 +172,7 @@ module.exports = function(grunt) {
 		"copy:package_to_drop_folder",
 		"copy:package_to_qa_drop_folder"
 	]);
+	grunt.registerTask("lint", ["tslint:build"]);
 
 	grunt.registerTask("default", "ts:devlib");
 };

lib/commands/add-library.ts

@@ -1,8 +1,7 @@
 ///<reference path="../.d.ts"/>
 "use strict";
 
-import path = require("path");
-import Future = require("fibers/future");
+import * as path from "path";
 
 export class AddLibraryCommand implements ICommand {
     constructor(private $platformService: IPlatformService,
@@ -14,8 +13,8 @@ export class AddLibraryCommand implements ICommand {
 
     execute(args: string[]): IFuture<void> {
         return (() => {
-            var platform = args[0];
-            var libraryPath = path.resolve(args[1]);
+            let platform = args[0];
+            let libraryPath = path.resolve(args[1]);
             this.$platformService.addLibrary(platform, libraryPath).wait();
             this.$logger.info(`Library ${libraryPath} was successfully added for ${platform} platform.`);
         }).future<void>()();
@@ -48,4 +47,4 @@ export class AddLibraryCommand implements ICommand {
         }).future<boolean>()();
     }
 }
-$injector.registerCommand("library|add", AddLibraryCommand);
+$injector.registerCommand("library|add", AddLibraryCommand);

lib/commands/add-platform.ts

@@ -25,4 +25,4 @@ export class AddPlatformCommand implements ICommand {
 		}).future<boolean>()();
 	}
 }
-$injector.registerCommand("platform|add", AddPlatformCommand);
+$injector.registerCommand("platform|add", AddPlatformCommand);

lib/commands/build.ts

@@ -23,7 +23,6 @@ export class BuildIosCommand extends BuildCommandBase implements  ICommand {
 }
 $injector.registerCommand("build|ios", BuildIosCommand);
 
-
 export class BuildAndroidCommand extends BuildCommandBase implements  ICommand {
 	constructor($platformService: IPlatformService,
 				private $platformsData: IPlatformsData) {

lib/commands/create-project.ts

@@ -36,6 +36,6 @@ export class CreateProjectCommand implements ICommand {
 		}).future<void>()();
 	}
 
-	allowedParameters = [new ProjectCommandParameter(this.$errors, this.$logger, this.$projectNameValidator) ]
+	allowedParameters = [new ProjectCommandParameter(this.$errors, this.$logger, this.$projectNameValidator) ];
 }
 $injector.registerCommand("create", CreateProjectCommand);

lib/commands/init.ts

@@ -1,8 +1,6 @@
 ///<reference path="../.d.ts"/>
 "use strict";
 
-import Future = require("fibers/future");
-
 export class InitCommand implements ICommand {
 	constructor(private $initService: IInitService) { }
 
@@ -13,4 +11,4 @@ export class InitCommand implements ICommand {
 		return this.$initService.initialize();
 	}
 }
-$injector.registerCommand("init", InitCommand);
+$injector.registerCommand("init", InitCommand);

lib/commands/install.ts

@@ -2,8 +2,6 @@
 "use strict";
 
 export class InstallCommand implements ICommand {
-	private _projectData: any;
-
 	constructor(private $platformsData: IPlatformsData,
 		private $platformService: IPlatformService,
 		private $projectData: IProjectData,
@@ -41,4 +39,4 @@ export class InstallCommand implements ICommand {
 		}).future<void>()();
 	}
 }
-$injector.registerCommand("install", InstallCommand);
+$injector.registerCommand("install", InstallCommand);

lib/commands/list-platforms.ts

@@ -2,18 +2,17 @@
 "use strict";
 
 import helpers = require("./../common/helpers");
-import util = require("util")
 
 export class ListPlatformsCommand implements ICommand {
 	constructor(private $platformService: IPlatformService,
 		private $logger: ILogger) { }
 
 	execute(args: string[]): IFuture<void> {
 		return (() => {
-			var installedPlatforms = this.$platformService.getInstalledPlatforms().wait();
+			let installedPlatforms = this.$platformService.getInstalledPlatforms().wait();
 
 			if(installedPlatforms.length > 0) {
-				var preparedPlatforms = this.$platformService.getPreparedPlatforms().wait();
+				let preparedPlatforms = this.$platformService.getPreparedPlatforms().wait();
 				if(preparedPlatforms.length > 0) {
 					this.$logger.out("The project is prepared for: ", helpers.formatListOfNames(preparedPlatforms, "and"));
 				} else {

lib/commands/livesync.ts

@@ -30,4 +30,4 @@ export class LivesyncCommand implements ICommand {
 
 	allowedParameters: ICommandParameter[] = [];
 }
-$injector.registerCommand("livesync", LivesyncCommand);
+$injector.registerCommand("livesync", LivesyncCommand);

lib/commands/plugin/remove-plugin.ts

@@ -27,4 +27,4 @@ export class RemovePluginCommand implements ICommand {
 
 	public allowedParameters: ICommandParameter[] = [];
 }
-$injector.registerCommand("plugin|remove", RemovePluginCommand);
+$injector.registerCommand("plugin|remove", RemovePluginCommand);

lib/commands/remove-platform.ts

@@ -25,4 +25,4 @@ export class RemovePlatformCommand implements ICommand {
 
 	allowedParameters: ICommandParameter[] = [];
 }
-$injector.registerCommand("platform|remove", RemovePlatformCommand);
+$injector.registerCommand("platform|remove", RemovePlatformCommand);

lib/commands/update-platform.ts

@@ -25,4 +25,4 @@ export class UpdatePlatformCommand implements ICommand {
 
 	allowedParameters: ICommandParameter[] = [];
 }
-$injector.registerCommand("platform|update", UpdatePlatformCommand);
+$injector.registerCommand("platform|update", UpdatePlatformCommand);

lib/config.ts

@@ -1,10 +1,9 @@
 ///<reference path=".d.ts"/>
 "use strict";
 
-import path = require("path");
-import util = require("util");
-import staticConfigBaseLibPath = require("./common/static-config-base");
-import configBaseLib = require("./common/config-base");
+import * as path from "path";
+import * as staticConfigBaseLibPath from "./common/static-config-base";
+import * as configBaseLib from "./common/config-base";
 
 export class Configuration extends configBaseLib.ConfigBase implements IConfiguration { // User specific config
 	CI_LOGGER = false;
@@ -37,7 +36,7 @@ export class StaticConfig extends staticConfigBaseLibPath.StaticConfigBase imple
 	}
 
 	public get SYS_REQUIREMENTS_LINK(): string {
-		var linkToSysRequirements: string;
+		let linkToSysRequirements: string;
 		switch(process.platform) {
 			case "linux":
 				linkToSysRequirements = "http://docs.nativescript.org/setup/ns-cli-setup/ns-setup-linux.html#system-requirements";

lib/constants.ts

@@ -1,14 +1,15 @@
 ///<reference path=".d.ts"/>
+"use strict";
 
-export var APP_FOLDER_NAME = "app";
-export var APP_RESOURCES_FOLDER_NAME = "App_Resources";
-export var PROJECT_FRAMEWORK_FOLDER_NAME = "framework";
-export var NATIVESCRIPT_KEY_NAME = "nativescript";
-export var NODE_MODULES_FOLDER_NAME = "node_modules";
-export var TNS_CORE_MODULES_NAME = "tns-core-modules";
-export var PACKAGE_JSON_FILE_NAME = "package.json";
-export var NODE_MODULE_CACHE_PATH_KEY_NAME = "node-modules-cache-path";
-export var DEFAULT_APP_IDENTIFIER_PREFIX = "org.nativescript";
+export let APP_FOLDER_NAME = "app";
+export let APP_RESOURCES_FOLDER_NAME = "App_Resources";
+export let PROJECT_FRAMEWORK_FOLDER_NAME = "framework";
+export let NATIVESCRIPT_KEY_NAME = "nativescript";
+export let NODE_MODULES_FOLDER_NAME = "node_modules";
+export let TNS_CORE_MODULES_NAME = "tns-core-modules";
+export let PACKAGE_JSON_FILE_NAME = "package.json";
+export let NODE_MODULE_CACHE_PATH_KEY_NAME = "node-modules-cache-path";
+export let DEFAULT_APP_IDENTIFIER_PREFIX = "org.nativescript";
 
 export class ReleaseType {
 	static MAJOR = "major";
@@ -19,5 +20,3 @@ export class ReleaseType {
 	static PREPATCH = "prepatch";
 	static PRERELEASE = "prerelease";
 }
-
-

lib/declarations.ts

@@ -88,4 +88,4 @@ interface IProjectFilesManager {
 
 interface IInitService {
 	initialize(): IFuture<void>;
-}
+}

lib/dynamic-help-provider.ts

@@ -1,18 +1,15 @@
 ///<reference path=".d.ts"/>
-
 "use strict";
 
 import Future = require("fibers/future");
 
 export class DynamicHelpProvider implements IDynamicHelpProvider {
-	constructor() { }
-
 	public isProjectType(args: string[]): IFuture<boolean> {
 		return Future.fromResult(true);
 	}
 
 	public getLocalVariables(options: { isHtml: boolean }): IFuture<IDictionary<any>> {
-		var localVariables: IDictionary<any> = {};
+		let localVariables: IDictionary<any> = {};
 		return Future.fromResult(localVariables);
 	}
 }

lib/lockfile.ts

@@ -3,7 +3,7 @@
 
 import Future = require("fibers/future");
 import lockfile = require("lockfile");
-import path = require("path");
+import * as path from "path";
 
 export class LockFile implements ILockFile {
 	private lockFilePath: string;
@@ -20,7 +20,7 @@ export class LockFile implements ILockFile {
 	};
 
 	public lock(): IFuture<void> {
-		var future = new Future<void>();
+		let future = new Future<void>();
 		lockfile.lock(this.lockFilePath, LockFile.LOCK_PARAMS, (err: Error) => {
 			if(err) {
 				future.throw(err);
@@ -32,7 +32,7 @@ export class LockFile implements ILockFile {
 	}
 
 	public unlock(): IFuture<void> {
-		var future = new Future<void>();
+		let future = new Future<void>();
 		lockfile.unlock(this.lockFilePath, (err: Error) => {
 			if(err) {
 				future.throw(err);
@@ -43,4 +43,4 @@ export class LockFile implements ILockFile {
 		return future;
 	}
 }
-$injector.register("lockfile", LockFile);
+$injector.register("lockfile", LockFile);

lib/mobile-platforms-capabilities.ts

@@ -24,7 +24,7 @@ export class MobilePlatformsCapabilities implements Mobile.IPlatformsCapabilitie
 				companion: false,
 				hostPlatformsForDeploy: ["win32", "darwin", "linux"]
 			}
-		}
+		};
 
 		return this.platformCapabilities;
 	}

lib/nativescript-cli.ts

@@ -1,6 +1,5 @@
 ///<reference path=".d.ts"/>
 "use strict";
-import path = require("path");
 require("./bootstrap");
 
 import fiber = require("fibers");
@@ -9,11 +8,11 @@ import errors = require("./common/errors");
 errors.installUncaughtExceptionListener();
 
 fiber(() => {
-	var config = <Config.IConfig>$injector.resolve("$config");
-	var err = <IErrors>$injector.resolve("$errors");
+	let config = <Config.IConfig>$injector.resolve("$config");
+	let err = <IErrors>$injector.resolve("$errors");
 	err.printCallStack = config.DEBUG;
 
-	var commandDispatcher: ICommandDispatcher = $injector.resolve("commandDispatcher");
+	let commandDispatcher: ICommandDispatcher = $injector.resolve("commandDispatcher");
 
 	if (process.argv[2] === "completion") {
 		commandDispatcher.completeCommand().wait();

lib/node-package-manager.ts

@@ -17,7 +17,7 @@ export class NodePackageManager implements INodePackageManager {
 	}
 
 	public load(config?: any): IFuture<void> {
-		var future = new Future<void>();
+		let future = new Future<void>();
 		npm.load(config, (err) => {
 			if(err) {
 				future.throw(err);
@@ -75,7 +75,7 @@ export class NodePackageManager implements INodePackageManager {
 			} else {
 				future.return(data);
 			}
-		}
+		};
 		args.push(callback);
 
 		let command = subCommandName ? npm.commands[commandName][subCommandName] : npm.commands[commandName];