Cocoapods support #769
Cocoapods support #769
Conversation
|
✅ |
| try { | ||
| this.$childProcess.exec("pod install", { cwd: this.platformData.projectRoot }).wait(); | ||
| } catch(e) { | ||
| this.$errors.failWithoutHelp("CocoaPods are not installed. Run `sudo gem install cocoapods` and try again."); |
There was a problem hiding this comment.
Shouldn't we display the error as well? For example CocoaPods might be installed but the command pod install to fail for some reason?
There was a problem hiding this comment.
This check must also be introduced in doctor command.
|
Consider adding checks for CocoaPods in the |
| let pluginPodFilePath = path.join(pluginPlatformsFolderPath, "Podfile"); | ||
| if(this.$fs.exists(pluginPodFilePath).wait()) { | ||
| let pluginPodFileContent = this.$fs.readText(pluginPodFilePath).wait(); | ||
| this.$fs.appendFile(this.projectPodFilePath, pluginPodFileContent).wait(); |
There was a problem hiding this comment.
Consider adding a comment in the general pod file mentioning that the code is from this given file.
|
Adding some unit tests for this functionality will be great. 👮 |
|
✅ |
| @@ -10,7 +10,7 @@ | |||
| }, | |||
| "main": "./lib/nativescript-cli.js", | |||
| "scripts": { | |||
| "test": "node_modules\\.bin\\_mocha --ui mocha-fibers --recursive --reporter spec --require test/test-bootstrap.js --timeout 60000 test/ lib/common/test/unit-tests", | |||
| "test": "node_modules\\.bin\\_mocha --ui mocha-fibers --recursive --reporter spec --require test/test-bootstrap.js --timeout 60000 test/ios-project-service", | |||
There was a problem hiding this comment.
I guess this change is leftover from debugging - but it currently breaks our test suite.
|
✅ |
| try { | ||
| this.$childProcess.exec("gem which cocoapods").wait(); | ||
| } catch(e) { | ||
| this.$errors.failWithoutHelp("CocoaPods are not installed. Run `sudo gem install cocoapods` and try again."); |
There was a problem hiding this comment.
The message on my machine is ERROR: Can't find ruby library file or shared library cocoapods. We must find another way to check for existence. Checking the exit code looks promising.
There was a problem hiding this comment.
We discussed the issue in person and we decided that the code is correct.
|
✅ |
|
✅ |
|
✅ |
|
Lets merge this, 👍 ! |
|
❌ |
|
✅ |
No description provided.