Skip to content

feat: custom android-studio path to support nixos using new env.NATIVESCRIPT_ANDROID_STUDIO_PATH #5816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 27, 2024
Merged

feat: custom android-studio path to support nixos using new env.NATIVESCRIPT_ANDROID_STUDIO_PATH #5816

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
69 changes: 38 additions & 31 deletions lib/key-commands/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,34 @@ export class ShiftA implements IKeyCommand {
private $projectData: IProjectData
) {}

getAndroidStudioPath(): string | null {
const os = currentPlatform();

if (os === "darwin") {
const possibleStudioPaths = [
"/Applications/Android Studio.app",
`${process.env.HOME}/Applications/Android Studio.app`,
];

return possibleStudioPaths.find((p) => fs.existsSync(p)) || null;
} else if (os === "win32") {
const studioPath = path.join(
"C:",
"Program Files",
"Android",
"Android Studio",
"bin",
"studio64.exe"
);
return fs.existsSync(studioPath) ? studioPath : null;
} else if (os === "linux") {
const studioPath = "/usr/local/android-studio/bin/studio.sh";
return fs.existsSync(studioPath) ? studioPath : null;
}

return null;
}

async execute(): Promise<void> {
this.$liveSyncCommandHelper.validatePlatform(this.platform);
this.$projectData.initializeProjectData();
Expand All @@ -65,53 +93,32 @@ export class ShiftA implements IKeyCommand {
}
}

const os = currentPlatform();
let studioPath = null;

if (os === "darwin") {
const possibleStudioPaths = [
"/Applications/Android Studio.app",
`${process.env.HOME}/Applications/Android Studio.app`,
];
studioPath = process.env.NATIVESCRIPT_ANDROID_STUDIO_PATH;

const studioPath = possibleStudioPaths.find((p) => {
this.$logger.trace(`Checking for Android Studio at ${p}`);
return fs.existsSync(p);
});
if (!studioPath) {
studioPath = this.getAndroidStudioPath();

if (!studioPath) {
this.$logger.error(
"Android Studio is not installed, or not in a standard location."
"Android Studio is not installed, or is not in a standard location. Use NATIVESCRIPT_ANDROID_STUDIO_PATH."
);
return;
}
}

const os = currentPlatform();
if (os === "darwin") {
this.$childProcess.exec(`open -a "${studioPath}" ${androidDir}`);
} else if (os === "win32") {
const studioPath = path.join(
"C:",
"Program Files",
"Android",
"Android Studio",
"bin",
"studio64.exe"
);
if (!fs.existsSync(studioPath)) {
this.$logger.error("Android Studio is not installed");
return;
}

const child = this.$childProcess.spawn(studioPath, [androidDir], {
detached: true,
stdio: "ignore",
});
child.unref();
} else if (os === "linux") {
if (!fs.existsSync(`/usr/local/android-studio/bin/studio.sh`)) {
this.$logger.error("Android Studio is not installed");
return;
}
this.$childProcess.exec(
`/usr/local/android-studio/bin/studio.sh ${androidDir}`
);
this.$childProcess.exec(`${studioPath} ${androidDir}`);
}
}
}
Expand Down