Copy styles for supported Android versions #566
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inside tns-android resources, there are values-v<API_LEVEL> directories. Currently we were copying only values-v21 in case the current project targets API_LEVEL 21. Instead we should copy it when the project targets API_LEVEL 21 or upper (in case there's no newer directory, for example values-v22). For example: * `$ tns platform add android --sdk 22` - should copy values and values-v21 in your platforms/android/res dir * `$ tns platform add android --sdk 21` - should copy values and values-v21 in your platforms/android/res dir * `$ tns platform add android --sdk MNC` - should copy values and values-v21 in your platforms/android/res dir * `$ tns platform add android --sdk 17` - should copy values in your platforms/android/res dir
|
✅ |
|
👍 |
|
👍 The lodash chain is awesome! |
rosen-vladimirov
added a commit
that referenced
this pull request
Jun 15, 2015
Copy styles for supported Android versions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inside tns-android resources, there are values-v<API_LEVEL> directories. Currently we were copying only values-v21 in case the current project targets API_LEVEL 21. Instead we should copy it when the project targets API_LEVEL 21 or upper (in case there's no newer directory, for example values-v22).
For example:
$ tns platform add android --sdk 22- should copy values and values-v21 in your platforms/android/res dir$ tns platform add android --sdk 21- should copy values and values-v21 in your platforms/android/res dir$ tns platform add android --sdk MNC- should copy values and values-v21 in your platforms/android/res dir$ tns platform add android --sdk 17- should copy values in your platforms/android/res dir