feat: doctor improvements #5178
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently each project related CLI command checks the status of the machine. This takes between 4 and 9 seconds on different machines. Cache the result per project and based on the environment variables used in the checks.
In case `tns doctor` is called, force the check of the environment requirements. In case an issue is detected, remove the file with cached information for all projects - there seems to be issue with the configuration, so we need to check all projects again.
rosen-vladimirov
force-pushed
the
vladimirov/doctor-improvements
branch
from
0b1e509 to
c601915
Compare
|
test cli-run cli-misc |
DimitarTachev
approved these changes
Dec 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently each project related CLI command checks the status of the machine. This takes between 4 and 9 seconds on different machines. Cache the result per project and based on the environment variables used in the checks.
In case
tns doctoris called, force the check of the environment requirements. In case an issue is detected, remove the file with cached information for all projects - there seems to be issue with the configuration, so we need to check all projects again.PR Checklist
What is the current behavior?
What is the new behavior?
Implements issue #5180.