chore: improve log trace messages #5171
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improve log trace messages with: 1. Remove some `containsNewerFiles` logs which do not give any useful information 2. Add trace for messages send by webpack process to CLI and the data prepared by CLI from those messages. 3. Printing the sysinfo information is now formatted correctly. 4. Print the current CLI version as it is not included in the sysinfo. 5. Override of SIGINT handler seems like an error in the trace logs - fix it by removing the "Error:" part from it.
DimitarTachev
approved these changes
Dec 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve log trace messages with:
containsNewerFileslogs which do not give any useful information