fix: sync all files when a HMR update is not possible in order to avoid multiple HMR syncs after restart #5163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

DimitarTachev merged 9 commits into master from tachev/fix-hmr-restart

Dec 5, 2019

Contributor

DimitarTachev commented Nov 26, 2019 •

edited by rosen-vladimirov

Loading

PR Checklist

The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/CONTRIBUTING.md#commit-messages.
There is an issue for the bug/feature this PR is for. To avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it.
You have signed the CLA.
All existing tests are passing: https://github.com/NativeScript/nativescript-cli/blob/master/CONTRIBUTING.md#contribute-to-the-code-base
Tests for the changes are included.

Related to: #5161 #5173


          fix: sync all files when a HMR update is not possible in order to avo…

…id multiple HMR syncs after restart

rosen-vladimirov approved these changes

View reviewed changes


          docs: fix template:process-markdowns grunt task in order to fix the d…

9236d04

…ocumentation build

cla-bot bot added the cla: yes label

DimitarTachev added 2 commits

December 2, 2019 08:46


          chore: fix typo

d938c80


          fix: sync all files when the app state does not support HOT updates i…

f8f3413

…n order to avoid multiple HMR syncs after restart

rosen-vladimirov approved these changes

View reviewed changes

DimitarTachev added 2 commits

December 2, 2019 14:39


          fix: do not assume the HMR status timeouts as errors because they cou…

c442253

…ld be caused by a breakpoint and we will kill the debug session


          fix: fix app files calculation in --no-hmr

5ce1cc9

Contributor Author

DimitarTachev commented Dec 2, 2019

test cli-run cli-templates cli-device


          fix: justlaunch should disable hmr

7177ad4

Currently when `--justlaunch` is passed, CLI still enables the HMR. However, this is not needed, as the `justlaunch` flag by design stops the command after running the application.

Contributor

rosen-vladimirov commented Dec 3, 2019

test cli-run cli-templates cli-device cli-debug

3 similar comments

Contributor Author

DimitarTachev commented Dec 4, 2019

test cli-run cli-templates cli-device cli-debug

Contributor

dtopuzov commented Dec 4, 2019

test cli-run cli-templates cli-device cli-debug

Contributor Author

DimitarTachev commented Dec 4, 2019

test cli-run cli-templates cli-device cli-debug


          chore: update packages with security issues and ios-sim-portable for …

1329a57

…frozen simulators fix

Contributor Author

DimitarTachev commented Dec 4, 2019

test cli-run cli-templates cli-device cli-debug

This was referenced Dec 5, 2019

chore(deps): bump marked from 0.5.1 to 0.6.1 #5143

Closed

chore(deps): bump open from 0.0.5 to 6.0.0 #5142

Closed

chore(deps): bump lodash from 4.17.11 to 4.17.13 #5112

Closed


          chore: update package lock files

875f1d2

Contributor Author

DimitarTachev commented Dec 5, 2019

test cli-run cli-templates cli-device cli-debug

dtopuzov mentioned this pull request

fix: debug start test NativeScript/nativescript-tooling-qa#451

Merged

DimitarTachev merged commit 65278fa into master

DimitarTachev deleted the tachev/fix-hmr-restart branch

December 5, 2019 14:46

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels