Skip to content

feat: show error when the project is not migrated and is not compatible for 6.0 release #4824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 10, 2019

Conversation

Fatme
Copy link
Contributor

@Fatme Fatme commented Jul 10, 2019

PR Checklist

What is the current behavior?

What is the new behavior?

Fixes/Implements/Closes #[Issue Number].

@cla-bot cla-bot bot added the cla: yes label Jul 10, 2019
@Fatme Fatme force-pushed the fatme/should-migrate branch from aa2c1f4 to 777eb21 Compare July 10, 2019 11:40
Fatme added 6 commits July 10, 2019 15:58
…the message shown at the end of migrate command
…grate action

Currently the version of nativescript-unit-test-runner is not checked on shouldMigrate action and this led to the behavior that shouldMigrate returns true for all projects that have `nativescript-unit-test-runner` as dependency.
@Fatme Fatme force-pushed the fatme/should-migrate branch from 777eb21 to fab55aa Compare July 10, 2019 13:00
@Fatme
Copy link
Contributor Author

Fatme commented Jul 10, 2019

test cli-smoke

@Fatme
Copy link
Contributor Author

Fatme commented Jul 10, 2019

test cli-smoke package_version#rc

@Fatme Fatme merged commit 497605a into release Jul 10, 2019
@Fatme Fatme deleted the fatme/should-migrate branch July 10, 2019 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants