Skip to content

fix: fix publish command #4772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 26, 2019
Merged

fix: fix publish command #4772

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/commands/appstore-upload.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ export class PublishIOS implements ICommand {
ipaFilePath = await this.$buildController.prepareAndBuild(buildData);
} else {
this.$logger.info("No .ipa, mobile provision or certificate set. Perfect! Now we'll build .xcarchive and let Xcode pick the distribution certificate and provisioning profile for you when exporting .ipa for AppStore submission.");
const buildData = new IOSBuildData(this.$projectData.projectDir, platform, { ...this.$options, buildForAppStore: true });
const buildData = new IOSBuildData(this.$projectData.projectDir, platform, { ...this.$options.argv, buildForAppStore: true });
ipaFilePath = await this.$buildController.prepareAndBuild(buildData);
this.$logger.info(`Export at: ${ipaFilePath}`);
}
Expand Down
1 change: 1 addition & 0 deletions lib/definitions/build.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ interface IBuildData extends IPrepareData {
emulator?: boolean;
clean: boolean;
buildForDevice?: boolean;
buildForAppStore?: boolean;
buildOutputStdio?: string;
outputPath?: string;
copyTo?: string;
Expand Down
8 changes: 4 additions & 4 deletions lib/services/ios-project-service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,12 +72,12 @@ export class IOSProjectService extends projectServiceBaseLib.PlatformProjectServ
appDestinationDirectoryPath: path.join(projectRoot, projectData.projectName),
platformProjectService: <any>this,
projectRoot: projectRoot,
getBuildOutputPath: (options: IBuildOutputOptions): string => {
getBuildOutputPath: (options: IBuildData): string => {
const config = getConfigurationName(!options || options.release);
return path.join(projectRoot, constants.BUILD_DIR, `${config}-${getPlatformSdkName(!options || options.buildForDevice)}`);
return path.join(projectRoot, constants.BUILD_DIR, `${config}-${getPlatformSdkName(!options || options.buildForDevice || options.buildForAppStore)}`);
},
getValidBuildOutputData: (buildOptions: IBuildOutputOptions): IValidBuildOutputData => {
const forDevice = !buildOptions || !!buildOptions.buildForDevice;
getValidBuildOutputData: (buildOptions: IBuildData): IValidBuildOutputData => {
const forDevice = !buildOptions || !!buildOptions.buildForDevice || !!buildOptions.buildForAppStore;
if (forDevice) {
return {
packageNames: [`${projectData.projectName}.ipa`]
Expand Down