feat: remove the auto-generated js, js.map and css files during app migration #4768
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DimitarTachev
force-pushed
the
tachev/remove-generated-files-on-migration
branch
from
f7fd0aa to
0e5bd40
Compare
rosen-vladimirov
approved these changes
Jun 26, 2019
| @@ -147,6 +157,52 @@ export class MigrateController extends UpdateControllerBase implements IMigrateC | |||
| this.$logger.info("Clean old project artefacts complete."); | |||
| } | |||
|
|
|||
| private handleAutoGeneratedFiles(backupDir: string, projectData: IProjectData): void { | |||
| const globOptions: glob.IOptions = { | |||
| silent: true, | |||
There was a problem hiding this comment.
maybe we can set this based on the log level?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
The auto-generated files from
nativescript-dev-sass,nativescript-dev-lessandnativescript-dev-typescript(js,js.mapandcssfiles) are not removed duringtns migratewhich could lead to Webpack compilation errors.What is the new behavior?
The auto-generated files are removed (moved to the
migration backupfolder) duringtns migrate