feat: migrate unit test related dependencies so tns test command can work out of the box with CLI v6.0
#4763
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n work out of the box with CLI v6.0 This PR makes the following changes: * install the latest nativescript-unit-test-runner * install the latest karma-webpack * update karma * update karma.conf.js * update karma-* plugins
Fatme
force-pushed
the
fatme/migrate-unit-test-runner
branch
from
e057b14 to
efdcf9a
Compare
| @@ -57,13 +64,13 @@ export class MigrateController extends UpdateControllerBase implements IMigrateC | |||
| //TODO update with no prerelease version compatible with webpack only hooks | |||
| { packageName: "nativescript-vue", verifiedVersion: "2.3.0-rc.0" }, | |||
| { packageName: "nativescript-permissions", verifiedVersion: "1.3.0" }, | |||
| { packageName: "nativescript-cardview", verifiedVersion: "3.2.0" } | |||
| { packageName: "nativescript-cardview", verifiedVersion: "3.2.0" }, | |||
| { packageName: "nativescript-unit-test-runner", verifiedVersion: "0.6.3", | |||
There was a problem hiding this comment.
We should consider handling both dev and prod dependencies.
DimitarTachev
approved these changes
Jun 25, 2019
Co-Authored-By: Dimitar Tachev <dimitar.tachev@telerik.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the following changes:
PR Checklist
What is the current behavior?
What is the new behavior?
Fixes/Implements/Closes #[Issue Number].