Skip to content

fix: fix release run for android #4677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 5, 2019
Merged

Conversation

Fatme
Copy link
Contributor

@Fatme Fatme commented Jun 5, 2019

PR Checklist

What is the current behavior?

tns run android --emulator --release --key-store-path <pathToKeyStoreFile> --key-store-password <keyStorePassword> --key-store-alias <keyStoreAlias> --key-store-alias-password <keyStoreAliasPassword> throws an error The "path" argument must be of type string. Received type undefined

What is the new behavior?

tns run android --emulator --release --key-store-path <pathToKeyStoreFile> --key-store-password <keyStorePassword> --key-store-alias <keyStoreAlias> --key-store-alias-password <keyStoreAliasPassword> works correctly

Fixes/Implements/Closes #[Issue Number].

@cla-bot cla-bot bot added the cla: yes label Jun 5, 2019
@Fatme Fatme changed the title Fatme/fix release run fix: fix release run for android Jun 5, 2019
@Fatme
Copy link
Contributor Author

Fatme commented Jun 5, 2019

test

@Fatme Fatme merged commit ff4ab70 into feature/webpack-only Jun 5, 2019
@Fatme Fatme deleted the fatme/fix-release-run branch June 5, 2019 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants