Skip to content

fix: pass --env.verbose to webpack compiler #4659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 31, 2019

Conversation

Fatme
Copy link
Contributor

@Fatme Fatme commented May 31, 2019

copy-webpack plugin prints its info messages on stderr by default. This led to the problem that these messages are shown in errors tab in Sidekick.
When { verbose: false } is provided as option to copy-webpack plugin, it doesn't print any information. So when tns run android is executed, no messages will be shown from copy-webpack plugin and thus no errors will be shown from Sidekick.

PR Checklist

What is the current behavior?

What is the new behavior?

Fixes/Implements/Closes #[Issue Number].

@cla-bot cla-bot bot added the cla: yes label May 31, 2019
@Fatme Fatme merged commit 39cccad into feature/webpack-only May 31, 2019
@Fatme Fatme deleted the fatme/verbose branch May 31, 2019 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants