Skip to content

fix: fix the workflow warnings on Windows #4566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 25, 2019

Conversation

DimitarTachev
Copy link
Contributor

Always split by "\n" as the string literals are always generating "/n" line terminators based on the below-mentioned ES specification.

More details: http://exploringjs.com/es6/ch_template-literals.html#_line-terminators-in-template-literals-are-always-lf-n

8.2.3 Line terminators in template literals are always LF (\n) #
Common ways of terminating lines are:

Line feed (LF, \n, U+000A): used by Unix (incl. current macOS)
Carriage return (CR, \r, U+000D): used by the old Mac OS.
CRLF (\r\n): used by Windows.
`All of these line terminators are normalized to LF in template literals.` That is, the following code logs true on all platforms:

const str = `BEFORE
AFTER`;
console.log(str === 'BEFORE\nAFTER'); // true

PR Checklist

Related to: #4548

… as the string literals are always generating "/n" terminating lines based on the below-mentioned ES specification)

More details here: http://exploringjs.com/es6/ch_template-literals.html#_line-terminators-in-template-literals-are-always-lf-n
8.2.3 Line terminators in template literals are always LF (\n) #
Common ways of terminating lines are:

Line feed (LF, \n, U+000A): used by Unix (incl. current macOS)
Carriage return (CR, \r, U+000D): used by the old Mac OS.
CRLF (\r\n): used by Windows.
`All of these line terminators are normalized to LF in template literals.` That is, the following code logs true on all platforms:

const str = `BEFORE
AFTER`;
console.log(str === 'BEFORE\nAFTER'); // true
@cla-bot cla-bot bot added the cla: yes label Apr 25, 2019
@ghost ghost assigned DimitarTachev Apr 25, 2019
@ghost ghost added new PR and removed cla: yes labels Apr 25, 2019
@DimitarTachev DimitarTachev merged commit 9283d29 into master Apr 25, 2019
@DimitarTachev DimitarTachev deleted the tachev/fix-workflow-warnings-windows branch April 25, 2019 10:45
@ghost ghost removed the new PR label Apr 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants