fix: debugging clients are now able to debug with debug-brk #4465
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we try to get debug socket in (tns debug ios --debug-brk), the additional app start is resuming the app and we are not able to debug the app start.
ghost
assigned 
Fatme
reviewed
Mar 22, 2019
| @@ -106,7 +106,7 @@ declare module Mobile { | |||
| } | |||
|
|
|||
| interface IiOSDevice extends IDevice { | |||
| getDebugSocket(appId: string, projectName: string): Promise<any>; | |||
| getDebugSocket(appId: string, projectName: string, ensureAppStarted?: boolean): Promise<any>; | |||
There was a problem hiding this comment.
boolean variable passed as param??? 🙀
There was a problem hiding this comment.
Its a temp flag till 5.3.1 -> #4466
rosen-vladimirov
approved these changes
Mar 22, 2019
miroslavaivanova
approved these changes
Mar 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
When we try to get debug socket in
tns debug ios --debug-brk, an additional app start is resuming the app and we are not able to debug the app start.What is the new behavior?
We are making an additional app start call only during LiveSync.