Skip to content

chore: remove installPods property from platform's project interface #4299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jan 30, 2019

Conversation

Fatme
Copy link
Contributor

@Fatme Fatme commented Jan 18, 2019

PR Checklist

What is the current behavior?

What is the new behavior?

Fixes/Implements/Closes #[Issue Number].

@Fatme Fatme added this to the 5.2.0 milestone Jan 18, 2019
@Fatme Fatme force-pushed the fatme/pod-tehnical-dept branch from b693036 to 8b01617 Compare January 21, 2019 06:16
@Fatme Fatme force-pushed the fatme/pod-tehnical-dept branch from d50eab9 to c7876f1 Compare January 21, 2019 12:59
@Fatme
Copy link
Contributor Author

Fatme commented Jan 22, 2019

run ci

Copy link
Contributor

@KristianDD KristianDD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After fixing comment if relevant.

Copy link
Contributor

@rosen-vladimirov rosen-vladimirov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can handle the comment in a separate PR

/**
* Gets the path wheren App_Resources should be copied.
* @returns {string} Path to native project, where App_Resources should be copied.
*/
getAppResourcesDestinationDirectoryPath(projectData: IProjectData): string;

cleanDeviceTempFolder(deviceIdentifier: string, projectData: IProjectData): Promise<void>;
processConfigurationFilesFromAppResources(projectData: IProjectData, opts: { release: boolean, installPods: boolean }): Promise<void>;
processConfigurationFilesFromAppResources(projectData: IProjectData, opts: { release: boolean }): Promise<void>;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

opts: IRelease

@Fatme Fatme merged commit e9d98ee into master Jan 30, 2019
@Fatme Fatme deleted the fatme/pod-tehnical-dept branch January 30, 2019 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants