Skip to content

docs: updates to the help #4039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 24, 2018
Merged

docs: updates to the help #4039

merged 3 commits into from
Oct 24, 2018

Conversation

ggarabedian
Copy link
Contributor

@ggarabedian ggarabedian commented Oct 17, 2018 •
edited by DimitarTachev
Loading

Unified and improved the commands help.

Related to #4057

Fatme
Fatme reviewed Oct 19, 2018
View reviewed changes
DimitarTachev
DimitarTachev reviewed Oct 19, 2018
View reviewed changes
Copy link
Contributor

@DimitarTachev DimitarTachev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The hmr option should be added to all run, preview and debug commands.

docs/man_pages/project/creation/create.md Outdated
`Vue.js`, `--vue`, `--vuejs` | tns-template-blank-vue
### Application Templates

Below you can see a list of all available NativeScript templates and the commands you can use to generate them.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are not all available NativeScript templates, they are just the recommended starting ones.

docs/man_pages/project/testing/preview.md Outdated

`--bundle` - Specifies that a bundler (e.g. webpack) should be used if one is present. If no value is passed it will default to `webpack`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really need to describe --bundle like this when the only supported option is webpack?

@ggarabedian ggarabedian force-pushed the ggarabed/update-help branch 3 times, most recently from 92f6735 to 04b5f5b Compare October 23, 2018 08:00
@ggarabedian
Copy link
Contributor Author

ggarabedian commented Oct 23, 2018 •
edited
Loading

@DimitarTachev, I have added the hmr flag to the run android/ios, preview and debug android/ios commands. Is the text "--hmr - Enables the hot module replacement (HMR) feature. HMR depends on webpack and requires the --bundle flag.`" correct?

@DimitarTachev
Copy link
Contributor

@DimitarTachev, I have added the hmr flag to the run android/ios, preview and debug android/ios commands. Is the text "--hmr - Enables the hot module replacement (HMR) feature. HMR depends on webpack and requires the --bundle flag.`" correct?

@ggarabedian, when you set the --hmr flag, it will use --bundle out of the box. In other words, it requires webpack, but you don't need to set both the --hmr and --bundle flags. --hmr and --bundle --hmr are equivalent.

@ggarabedian ggarabedian force-pushed the ggarabed/update-help branch 4 times, most recently from d691619 to c70c2e8 Compare October 24, 2018 08:26
@Fatme Fatme added this to the 5.0.0 milestone Oct 24, 2018
@ggarabedian ggarabedian force-pushed the ggarabed/update-help branch 3 times, most recently from 856651b to c4742f9 Compare October 24, 2018 11:47
@DimitarTachev DimitarTachev merged commit 71f1abe into release Oct 24, 2018
@DimitarTachev DimitarTachev deleted the ggarabed/update-help branch October 24, 2018 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fatme Fatme Fatme left review comments

@DimitarTachev DimitarTachev DimitarTachev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.
5 participants
@ggarabedian @DimitarTachev @Fatme @msc-ddiaz @rosen-vladimirov