Skip to content

chore: persist warnings per preview app's version when comparing plugins from preview app with local plugins #3899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 17, 2018

Conversation

Fatme
Copy link
Contributor

@Fatme Fatme commented Sep 17, 2018

In case when QR code is scanned with 2 different devices with the same version of preview app, {N} CLI will compares 2 times plugins from preview app with local plugins.

PR Checklist

What is the current behavior?

{N} CLI compares 2 times plugins from preview app with local plugins when QR code is scanned with 2 different devices with the same version of preview app.

What is the new behavior?

{N} CLI compares only once plugins from preview app with local plugins when QR code is scanned with 2 different devices with the same version of preview app.

@Fatme Fatme merged commit 943339f into master Sep 17, 2018
@Fatme Fatme deleted the fatme/preview-app-warnings branch September 17, 2018 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants