Respect timeout option when getting debugger port #3817
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes when debug command is executed, an error is thrown because {N} CLI is not able to get debugger's port from device's logs. Currently {N} CLI tries 10 times (the retryCount) to get the port every 500 miliseconds. If the port is not found, an error is thrown. This PR calculates the retry count based on timeout option.
In case no timeout option is specified {N} CLI will try 20 times to get the port (this is the difference with the current behaviour).
In case when calculated retry count is lower then 10, {N} CLI will try 10 times to get the port.
PR Checklist