Skip to content

Respect timeout option when getting debugger port #3817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 14, 2018

Conversation

Fatme
Copy link
Contributor

@Fatme Fatme commented Aug 13, 2018

Sometimes when debug command is executed, an error is thrown because {N} CLI is not able to get debugger's port from device's logs. Currently {N} CLI tries 10 times (the retryCount) to get the port every 500 miliseconds. If the port is not found, an error is thrown. This PR calculates the retry count based on timeout option.
In case no timeout option is specified {N} CLI will try 20 times to get the port (this is the difference with the current behaviour).
In case when calculated retry count is lower then 10, {N} CLI will try 10 times to get the port.

PR Checklist

@Fatme
Copy link
Contributor Author

Fatme commented Aug 14, 2018

run ci

@Fatme Fatme merged commit 5feb88f into release Aug 14, 2018
@Fatme Fatme deleted the fatme/debug-timeout-option branch August 14, 2018 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants