Skip to content

Skip local prepare when executing cloud build from sidekick and no project's file is changed #3764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 17, 2018

Conversation

Fatme
Copy link
Contributor

@Fatme Fatme commented Jul 23, 2018

Platform prepare is never skipped when executing cloud build for iOS from sidekick. The reason for this is the signingChanged property from changesInfo is always true and thus shouldPrepare is always true. signingChanged property is set to true inside ios-project-service because pbxproject file does not exist. Actually locally from sidekick pbxproject file is never created. So the file never exists. This PR speeds the the cloud build for iOS with around 2-3 sec.

PR Checklist

What is the current behavior?

Local prepare is not skipped when no project's file is changed.

What is the new behavior?

Local prepare is skipped when no project's file is changed.

@Fatme Fatme added this to the 4.2.1 milestone Jul 23, 2018
@rosen-vladimirov rosen-vladimirov modified the milestones: 4.2.1, 4.2.2 Aug 7, 2018
@Fatme Fatme modified the milestones: 4.2.2, 4.2.3 Aug 15, 2018
@Fatme Fatme merged commit b5e0aa0 into master Sep 17, 2018
@Fatme Fatme deleted the fatme/fix-check-for-changes branch September 17, 2018 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants