Skip local prepare when executing cloud build from sidekick and no project's file is changed #3764
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platform prepare is never skipped when executing cloud build for iOS from sidekick. The reason for this is the
signingChanged
property fromchangesInfo
is always true and thusshouldPrepare
is always true.signingChanged
property is set to true insideios-project-service
becausepbxproject
file does not exist. Actually locally from sidekickpbxproject
file is never created. So the file never exists. This PR speeds the the cloud build for iOS with around 2-3 sec.PR Checklist
What is the current behavior?
Local prepare is not skipped when no project's file is changed.
What is the new behavior?
Local prepare is skipped when no project's file is changed.