chore: fix the template name that will be send to google analytics #3725
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fatme
changed the title
Fatme
changed the title
rosen-vladimirov
approved these changes
Jul 4, 2018
| @@ -92,7 +92,7 @@ export class ProjectTemplatesService implements IProjectTemplatesService { | |||
| private getTemplateNameToBeTracked(templateName: string, packageJsonContent: any): string { | |||
| try { | |||
| if (this.$fs.exists(templateName)) { | |||
| const templateNameToBeTracked = this.$fs.exists(path.join(templateName, constants.PACKAGE_JSON_FILE_NAME)) ? packageJsonContent.name : path.basename(templateName); | |||
| const templateNameToBeTracked = packageJsonContent && packageJsonContent.name ? packageJsonContent.name : path.basename(templateName); | |||
There was a problem hiding this comment.
this could be shorten:
const templateNameToBeTracked = (packageJsonContent && packageJsonContent.name) || path.basename(templateName);But I do not insist changing it.
Fatme
force-pushed
the
fatme/fix-tracked-template-name
branch
from
5694c83 to
44bb8ca
Compare
rosen-vladimirov
approved these changes
Jul 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix data send to google analytics when
tns create --template <localTemplatePath>command is executed.Expected:
localTemplate_tns-template-hello-worldCurrent:
localTemplate_livesync-hello-world.tgzPR Checklist
What is the current behavior?
tns create myApp --template <localTemplatePath>sends wrong data to google analyticsWhat is the new behavior?
tns create myApp --template <localTemplatePath>sends correct data to google analytics