Skip to content

Speed up android livesync #3692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 14, 2018
Merged

Speed up android livesync #3692

merged 2 commits into from
Sep 14, 2018

Conversation

Fatme
Copy link
Contributor

@Fatme Fatme commented Jun 19, 2018

tns run android command transfers all files on initial sync. Actually there is no need to transfer all files on device because the installed .apk contains them. So after the application is installed on device, calculate the hashes for files inside \plaforms\android\app\* and upload the hash file on device. When the initial sync is executed {N} CLI compares the hashes and no file is transferred on device because all files are the same (no change is occurred). This PR speeds up the initial livesync with around 15seconds for angular application.

PR Checklist

What is the current behavior?

LiveSync for android always transfer all project files on device but actually no need to do it.

What is the new behavior?

LiveSync for android is faster.

@Natalia-Hristova Natalia-Hristova added this to the 4.2.0 milestone Jul 6, 2018
@rosen-vladimirov rosen-vladimirov modified the milestones: 4.2.0, 4.2.1 Jul 17, 2018
@Fatme Fatme force-pushed the fatme/faster-android-livesync branch from ec4532f to 8d70a7b Compare July 23, 2018 10:48
@Fatme Fatme force-pushed the fatme/faster-android-livesync branch 5 times, most recently from 781dbec to a6d0c24 Compare August 7, 2018 08:49
@rosen-vladimirov rosen-vladimirov modified the milestones: 4.2.1, 4.2.2 Aug 7, 2018
@Fatme Fatme force-pushed the fatme/faster-android-livesync branch 6 times, most recently from 851ddb3 to faf7970 Compare August 13, 2018 05:54
@dtopuzov
Copy link
Contributor

run ci

@Fatme Fatme modified the milestones: 4.2.2, 4.2.3 Aug 15, 2018
@Fatme Fatme changed the base branch from release to master September 5, 2018 07:54
@Fatme Fatme force-pushed the fatme/faster-android-livesync branch from faf7970 to 7767381 Compare September 13, 2018 13:16
@rosen-vladimirov rosen-vladimirov modified the milestones: 4.2.3, 5.0.0 Sep 14, 2018
… hashes -> Extract all this logic to base class and reuse it from livesync with sockets and old livesync service

Remove all $options from services
@Fatme Fatme force-pushed the fatme/faster-android-livesync branch from 7767381 to 54003cc Compare September 14, 2018 12:30
@Fatme Fatme merged commit e34d148 into master Sep 14, 2018
@Fatme Fatme deleted the fatme/faster-android-livesync branch December 7, 2018 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants