Fix tns run ios --justlaunch
#3657
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fatme
force-pushed
the
fatme/fix-justlaunch
branch
from
e444bc5 to
8efec72
Compare
Fatme
force-pushed
the
fatme/fix-justlaunch
branch
from
8efec72 to
55b5813
Compare
rosen-vladimirov
suggested changes
Jun 5, 2018
lib/services/debug-service.ts
Outdated
| @@ -51,7 +51,7 @@ export class DebugService extends EventEmitter implements IDebugService { | |||
| this.$errors.failWithoutHelp(`Unsupported device OS: ${device.deviceInfo.platform}. You can debug your applications only on iOS or Android.`); | |||
| } | |||
|
|
|||
| if (this.$mobileHelper.isiOSPlatform(device.deviceInfo.platform)) { | |||
| if (this.$mobileHelper.isiOSPlatform(device.deviceInfo.platform)) { // TODO: Consider to move this code to ios-debug-service | |||
There was a problem hiding this comment.
Please move the TODO above the code
| @@ -456,8 +456,11 @@ export class LiveSyncService extends EventEmitter implements IDebugLiveSyncServi | |||
| const deviceAction = async (device: Mobile.IDevice): Promise<void> => { | |||
| try { | |||
| const platform = device.deviceInfo.platform; | |||
| const liveSyncService = this.getLiveSyncService(platform); | |||
There was a problem hiding this comment.
this should be called const platformLiveSyncService
rosen-vladimirov
approved these changes
Jun 12, 2018
|
run ci |
|
run ci |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case when
tns run ios --justlaunchcommand is executed on real iOS device, the console should be released and the process should exit. Actually the process does not exit because a device's log process is started and this prevents the console to be released. So this PR fixes this behaviour.Fixes #3644
PR Checklist
What is the current behavior?
The console is not released when
tns run ios --justlaunchcommand is executed.What is the new behavior?
The console is released when
tns run ioscommand is executed.